[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111849: custom first week for plasmaclock.
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-08-24 19:02:41
Message-ID: 20130824190241.31530.94335 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 20, 2013, 9:03 a.m., Sebastian Kügler wrote:
> > * The patch is not correctly submitted, it's submitted as screenshot, not as patch, that \
> > makes it impossible to review
> > * You didn't attach a screenshot of the UI
> > * Checking wether a patch applies is not testing it
> > * The clock's config is not the right place for this, it should rather be a global calendar \
> > setting
> > * kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not \
> > about)
> > Please read and address my comments more carefully.
>
> Hu Zheng wrote:
> If I submit it as a patch, it will need a Parent Diff, which I don't have in fact.
> The screenshot is added!
> You can see the new patch file, it changed to use custom config file.
The parent diff is optional. Please also address my other comments.
- Sebastian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111849/#review38189
-----------------------------------------------------------
On Aug. 24, 2013, 7:46 a.m., Hu Zheng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111849/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 7:46 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> In normal case, the first week is the first week in the year, but the teachers may want to \
> custom the first week, for example, make the 8th week as the first week, then the 9th week \
> will be the second week, and so on. Then the teacher can easily do their work as a custom \
> teaching period!
>
> Diffs
> -----
>
>
> Diff: http://git.reviewboard.kde.org/r/111849/diff/
>
>
> Testing
> -------
>
> cd kde-workspace-4.10.5/libs/plasmaclock
> patch -p1 < customfirstweek.patch
>
> The save configuration codes are not very beautiful, but it works fine!
>
>
> File Attachments
> ----------------
>
> patch
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch
> another patch, use custom config file.
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch
> screenshot
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png
>
>
> Thanks,
>
> Hu Zheng
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111849/">http://git.reviewboard.kde.org/r/111849/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2013, 9:03 a.m. UTC, <b>Sebastian Kügler</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">* The patch is not correctly submitted, \
it's submitted as screenshot, not as patch, that makes it impossible to \
review
* You didn't attach a screenshot of the UI
* Checking wether a patch applies is not testing it
* The clock's config is not the right place for this, it should rather be a global calendar \
setting
* kde-workspace is frozen, this could, *at best* go into Plasma2 (which this patch is not \
about)
Please read and address my comments more carefully.</pre>
</blockquote>
<p>On August 24th, 2013, 7:46 a.m. UTC, <b>Hu Zheng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">If I submit it as a patch, it will need a \
Parent Diff, which I don't have in fact. The screenshot is added!
You can see the new patch file, it changed to use custom config file.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">The parent diff is optional. Please also \
address my other comments.</pre> <br />
<p>- Sebastian</p>
<br />
<p>On August 24th, 2013, 7:46 a.m. UTC, Hu Zheng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Hu Zheng.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 7:46 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In normal case, the \
first week is the first week in the year, but the teachers may want to custom the first week, \
for example, make the 8th week as the first week, then the 9th week will be the second week, \
and so on. Then the teacher can easily do their work as a custom teaching period!</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">cd \
kde-workspace-4.10.5/libs/plasmaclock patch -p1 < customfirstweek.patch
The save configuration codes are not very beautiful, but it works fine!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111849/diff/" style="margin-left: 3em;">View \
Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/customfirstweek.patch">patch</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/20/customweek.patch">another \
patch, use custom config file.</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/customweek.png">screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic