[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112236: krunner: Add the full name of completion matches to history
From: "Harald Hvaal" <harald.hvaal () gmail ! com>
Date: 2013-08-24 10:17:01
Message-ID: 20130824101701.22696.70907 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 24, 2013, 10:08 a.m., Thomas Lübking wrote:
> > kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml, line 274
> > <http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274>
> >
> > ... ;-)
yeah, not sure what happened with post-review here, but it's definitely not part of \
the actual commit :)
- Harald
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112236/#review38466
-----------------------------------------------------------
On Aug. 24, 2013, 9:52 a.m., Harald Hvaal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112236/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 9:52 a.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Description
> -------
>
> Previously you would not record the actual item you chose after choosing an \
> auto-completion, so if you typed say "lal" and you chose a completion way down the \
> list, the history item would not reflect that choice, only what you typed to get to \
> the completion list.
> This commit will fill the history combo box with the actual hit you executed, \
> instead of half-complete strings that don't make sense until you actually select \
> them. Exact matches are added as-is.
>
> example: type ass, and you get Qt Assistant. Instead of adding "ass" to the \
> history, "Qt Assistant" will be added.
>
> Diffs
> -----
>
> krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104
> kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml \
> 8832d1d03e47a4e6382877d18ee664ecd4d12343
> Diff: http://git.reviewboard.kde.org/r/112236/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harald Hvaal
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112236/">http://git.reviewboard.kde.org/r/112236/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 24th, 2013, 10:08 a.m. UTC, <b>Thomas \
Lübking</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112236/diff/1/?file=184315#file184315line274" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">274</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">textFormat:</span> <span class="nx">Text</span><span \
class="p">.</span><span class="nx">PlainText</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">... ;-)</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah, not \
sure what happened with post-review here, but it's definitely not part of the \
actual commit :)</pre> <br />
<p>- Harald</p>
<br />
<p>On August 24th, 2013, 9:52 a.m. UTC, Harald Hvaal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Harald Hvaal.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2013, 9:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Previously you would not record the actual item you chose after choosing \
an auto-completion, so if you typed say "lal" and you chose a completion \
way down the list, the history item would not reflect that choice, only what you \
typed to get to the completion list.
This commit will fill the history combo box with the actual hit you executed, instead \
of half-complete strings that don't make sense until you actually select them. \
Exact matches are added as-is.
example: type ass, and you get Qt Assistant. Instead of adding "ass" to the \
history, "Qt Assistant" will be added.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/interfaces/default/interface.cpp <span style="color: \
grey">(505e0aa6c02233fba0ff7ae9ce1133e8c7542104)</span></li>
<li>kwin/clients/aurorae/themes/plastik/package/contents/ui/main.qml <span \
style="color: grey">(8832d1d03e47a4e6382877d18ee664ecd4d12343)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112236/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic