[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112157: replace deprecated widgets
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2013-08-19 15:21:05
Message-ID: 20130819152105.17696.22672 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/#review38149
-----------------------------------------------------------
Ship it!
One comment below needs addressing.
engineexplorer/main.cpp
<http://git.reviewboard.kde.org/r/112157/#comment28200>
This looks like it leaks.
- David Edmundson
On Aug. 19, 2013, 2:45 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112157/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2013, 2:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> * this replaces the deprecated widgets from the plasmaengineexplorer
> * makes the serviceviewer.ui nicer( I have attached a screenshot)
>
>
> Diffs
> -----
>
> engineexplorer/CMakeLists.txt 1466542
> engineexplorer/engineexplorer.h 5c19fa6
> engineexplorer/engineexplorer.cpp a3f2e1f
> engineexplorer/engineexplorer.ui 65e70b4
> engineexplorer/ktreeviewsearchline.cpp 734ef94
> engineexplorer/main.cpp 8eae7a3
> engineexplorer/serviceviewer.h dc0b36b
> engineexplorer/serviceviewer.cpp d7e8e5a
> engineexplorer/serviceviewer.ui b91b784
>
> Diff: http://git.reviewboard.kde.org/r/112157/diff/
>
>
> Testing
> -------
>
> it is building/installing/working correctly. I have noticed any issue
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112157/">http://git.reviewboard.kde.org/r/112157/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One comment below needs \
addressing.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/112157/diff/1/?file=183489#file183489line95" \
style="color: black; font-weight: bold; text-decoration: \
underline;">engineexplorer/main.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
main(int argc, char **argv)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">93</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineArgs</span><span class="o">::</span><span \
class="n">addCmdLineOptions</span><span class="p">(</span><span \
class="n">options</span><span class="p">);</span></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">79</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QCommandLineParser</span> <span class="o">*</span><span \
class="n">parser</span> <span class="o">=</span> <span class="k">new</span> <span \
class="n">QCommandLineParser</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks \
like it leaks. </pre>
</div>
<br />
<p>- David</p>
<br />
<p>On August 19th, 2013, 2:45 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2013, 2:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it is building/installing/working correctly. I have noticed any \
issue</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engineexplorer/CMakeLists.txt <span style="color: grey">(1466542)</span></li>
<li>engineexplorer/engineexplorer.h <span style="color: grey">(5c19fa6)</span></li>
<li>engineexplorer/engineexplorer.cpp <span style="color: \
grey">(a3f2e1f)</span></li>
<li>engineexplorer/engineexplorer.ui <span style="color: grey">(65e70b4)</span></li>
<li>engineexplorer/ktreeviewsearchline.cpp <span style="color: \
grey">(734ef94)</span></li>
<li>engineexplorer/main.cpp <span style="color: grey">(8eae7a3)</span></li>
<li>engineexplorer/serviceviewer.h <span style="color: grey">(dc0b36b)</span></li>
<li>engineexplorer/serviceviewer.cpp <span style="color: grey">(d7e8e5a)</span></li>
<li>engineexplorer/serviceviewer.ui <span style="color: grey">(b91b784)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112157/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png">layout.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic