[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112033: Drop windowId property from PlasmaCore.Dialog
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-08-19 8:55:05
Message-ID: 20130819085505.19825.59989 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 19, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote:
> > FWIW this is also being used in the KTp chat plasmoid, in a hack so the dialog \
> > doesn't appear in the tasks list.
well that should be done differently. IIRC the PlasmaCore.Dialog already exposes a \
flags attribute, so we should make sure that also the SkipTaksbar|SkipPager flags are \
respected.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112033/#review38100
-----------------------------------------------------------
On Aug. 13, 2013, 6:47 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112033/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2013, 6:47 a.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> Property windowId was according to the comments only provided because KWin needed \
> it. KWin's usecase was to know the window Id of the window where a given item is \
> rendered to. In QtQuick a QQuickItem provides a pointer to the QQuickWindow holding \
> the item. This means this hack is no longer needed.
>
> Diffs
> -----
>
> src/declarativeimports/core/dialog.h 7392b71
> src/declarativeimports/core/dialog.cpp eaf3dce
>
> Diff: http://git.reviewboard.kde.org/r/112033/diff/
>
>
> Testing
> -------
>
> Yes, KWin's ThumnailItem is still working
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112033/">http://git.reviewboard.kde.org/r/112033/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 19th, 2013, 10:33 a.m. CEST, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">FWIW this is also being used in the KTp chat plasmoid, in a hack so the \
dialog doesn't appear in the tasks list.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">well that should be done \
differently. IIRC the PlasmaCore.Dialog already exposes a flags attribute, so we \
should make sure that also the SkipTaksbar|SkipPager flags are respected.</pre> <br \
/>
<p>- Martin</p>
<br />
<p>On August 13th, 2013, 6:47 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Aug. 13, 2013, 6:47 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Property windowId was according to the comments only provided because \
KWin needed it. KWin's usecase was to know the window Id of the window where a \
given item is rendered to. In QtQuick a QQuickItem provides a pointer to the \
QQuickWindow holding the item. This means this hack is no longer needed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, KWin's ThumnailItem is still working</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/core/dialog.h <span style="color: \
grey">(7392b71)</span></li>
<li>src/declarativeimports/core/dialog.cpp <span style="color: \
grey">(eaf3dce)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112033/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic