[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2013-08-16 10:01:13
Message-ID: 20130816100113.8653.25835 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 24, 2013, 6:51 p.m., Marco Martin wrote:
> > Ship It!
>
> Albert Astals Cid wrote:
> Janitorial dude question: Has this been commited and you forgot to mark it as \
> submitted or it does still need submitting?
>
> Kai Uwe Broulik wrote:
> Marco did some changes to that part in the meantime [1] and I cannot really \
> reproduce the problem anymore for a long time now, seems the close signal is \
> emitted even when you're dragging the popup on the button and then release.
> [1] http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=77a3bf4aca1e876fd234eaa15ad58f984b6b9d54
>
So shall we discard this?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------
On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2012, 2:43 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Description
> -------
>
> This patch disables the setCustomNotification while a button (close, next, back) is \
> pressed, to prevent popup re-shifting which seems to eat the clicked event. Problem \
> is more deep in Plasma but has been around since Plasma exists, so this should fix \
> it for the notifications.
>
> This addresses bug 311413.
> http://bugs.kde.org/show_bug.cgi?id=311413
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b
>
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
>
>
> Testing
> -------
>
> kdialog --passivepopup "bla"
> click, closes.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107908/">http://git.reviewboard.kde.org/r/107908/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 24th, 2013, 6:51 p.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
<p>On August 15th, 2013, 10:12 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Janitorial dude \
question: Has this been commited and you forgot to mark it as submitted or it does \
still need submitting? </pre>
</blockquote>
<p>On August 16th, 2013, 9:57 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Marco did some changes \
to that part in the meantime [1] and I cannot really reproduce the problem anymore \
for a long time now, seems the close signal is emitted even when you're dragging \
the popup on the button and then release.
[1] http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=77a3bf4aca1e876fd234eaa15ad58f984b6b9d54
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So shall we discard \
this?</pre> <br />
<p>- Albert</p>
<br />
<p>On December 25th, 2012, 2:43 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Marco Martin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Dec. 25, 2012, 2:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch disables the setCustomNotification while a button (close, \
next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked \
event. Problem is more deep in Plasma but has been around since Plasma exists, so \
this should fix it for the notifications.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdialog --passivepopup "bla" click, closes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311413">311413</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(e63526b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107908/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic