'Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + bet'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108325: LastNotificationPopup fix for closing not to move + add move button + bet
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-08-15 22:03:56
Message-ID: 20130815220356.17501.17808 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108325/
-----------------------------------------------------------

(Updated Aug. 15, 2013, 10:03 p.m.)

Status
------

This change has been discarded.

Review request for Plasma and Marco Martin.

Description
-------

Fixes the LastNotificationsPopup moving around when clicking on a button and adds a \
move button to freely place it all over the desktop.  Also this removes notifications \
jobs from the notification icon. (So clicking on X does not hide but really closes \
the notification and removes it) Also this fixes layout problems with 3 buttons \
displayed inside a notification (this caused the X button to overlap with the upper \
actionbutton).

As my original diff was not recognized as normal diff(don't know what I did wrong \
there) I attached the patch directly to this thread. 

This addresses bug 311413.
    http://bugs.kde.org/show_bug.cgi?id=311413

Diffs
-----

Diff: http://git.reviewboard.kde.org/r/108325/diff/

Testing
-------

kdialog --passivepopup "bla"
click on X, closes and removes job from notification Icon
click and hold on move button moves the popup freely on the screen. 

File Attachments
----------------

Patch
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff

Thanks,

Leszek Lesner

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108325/">http://git.reviewboard.kde.org/r/108325/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Leszek Lesner.</div>

<p style="color: grey;"><i>Updated Aug. 15, 2013, 10:03 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes the LastNotificationsPopup moving around when clicking on a button \
and adds a move button to freely place it all over the desktop.  Also this removes \
notifications jobs from the notification icon. (So clicking on X does not hide but \
really closes the notification and removes it) Also this fixes layout problems with 3 \
buttons displayed inside a notification (this caused the X button to overlap with the \
upper actionbutton).

As my original diff was not recognized as normal diff(don&#39;t know what I did wrong \
there) I attached the patch directly to this thread. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdialog --passivepopup &quot;bla&quot; click on X, closes and removes \
job from notification Icon click and hold on move button moves the popup freely on \
the screen. </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=311413">311413</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108325/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>

<ul>

 <li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/10/LastNotificationPopup_patch.diff">Patch</a></li>

</ul>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 