[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111863: Feature: Folder Preview in Local Pictures Browsing
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-08-08 18:18:41
Message-ID: 20130808181841.12579.52405 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111863/#review37374
-----------------------------------------------------------
Ship it!
Works fine, just fix the little issues below and push
browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27652>
if needs braces {}
browsingbackends/localfiles/localpictures/localpicturesmodel.cpp
<http://git.reviewboard.kde.org/r/111863/#comment27651>
indentation needs to be fixed
- Shantanu Tushar
On Aug. 8, 2013, 2:30 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111863/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2013, 2:30 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Description
> -------
>
> Folder Contents(Images) are previewed when we browse the local directories for Pictures.
>
>
> Diffs
> -----
>
> browsingbackends/localfiles/localpictures/CMakeLists.txt 2acbd59
> browsingbackends/localfiles/localpictures/localpicturesmodel.h d61f2a3
> browsingbackends/localfiles/localpictures/localpicturesmodel.cpp afb852f
> browsingbackends/localfiles/localthumbnailprovider.h PRE-CREATION
> browsingbackends/localfiles/localthumbnailprovider.cpp PRE-CREATION
> browsingbackends/localfiles/localvideos/CMakeLists.txt 3cac82c
> browsingbackends/localfiles/localvideos/localvideosmodel.h 3b4b668
> browsingbackends/localfiles/localvideos/localvideosmodel.cpp 6bdf386
> browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h d485b11
> browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp d666ac4
>
> Diff: http://git.reviewboard.kde.org/r/111863/diff/
>
>
> Testing
> -------
>
> Yes. Works fine.
>
>
> Thanks,
>
> Akshay Ratan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111863/">http://git.reviewboard.kde.org/r/111863/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine, just fix the \
little issues below and push</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111863/diff/5/?file=177371#file177371line45" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localpictures/localpicturesmodel.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">32</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">LocalPicturesModel</span><span class="o">::</span><span \
class="n">data</span><span class="p">(</span><span class="n">index</span><span \
class="p">,</span> <span class="n">MediaCenter</span><span class="o">::</span><span \
class="n">IsExpandableRole</span><span class="p">).</span><span \
class="n">toBool</span><span class="p">())</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">45</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">LocalPicturesModel</span><span class="o">::</span><span \
class="n">data</span><span class="p">(</span><span class="n">index</span><span \
class="p">,</span> <span class="n">MediaCenter</span><span class="o">::</span><span \
class="n">IsExpandableRole</span><span class="p">).</span><span \
class="n">toBool</span><span class="p">())</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">33</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="n">LocalFilesAbstractModel</span><span \
class="o">::</span><span class="n">data</span> <span class="p">(</span><span \
class="n">index</span><span class="p">,</span> <span \
class="n">MediaCenter</span><span class="o">::</span><span \
class="n">MediaUrlRole</span><span class="p">);</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">46</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span class="n">LocalFilesAbstractModel</span><span \
class="o">::</span><span class="n">data</span> <span class="p">(</span><span \
class="n">index</span><span class="p">,</span> <span \
class="n">MediaCenter</span><span class="o">::</span><span \
class="n">MediaUrlRole</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">if needs \
braces {}</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111863/diff/5/?file=177371#file177371line47" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localpictures/localpicturesmodel.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">47</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">else</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">48</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span \
class="n">m_thumbProvider</span><span class="o">-></span><span \
class="n">hasThumbnail</span><span class="p">(</span><span class="n">url</span><span \
class="p">))</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">49</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">return</span> <span \
class="s">"image://localpicturesthumbnail/"</span> <span class="o">+</span> \
<span class="n">url</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span> <span class="k">else</span> <span class="p">{</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">m_thumbProvider</span><span class="o">-></span><span \
class="n">loadThumbnail</span><span class="p">(</span><span \
class="n">KUrl</span><span class="p">(</span><span class="n">url</span><span \
class="p">),</span> <span class="n">QSize</span><span class="p">(</span><span \
class="mi">600</span><span class="p">,</span> <span class="mi">600</span><span \
class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">52</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">m_pendingThumbs</span><span class="p">.</span><span \
class="n">insert</span><span class="p">(</span><span class="n">url</span><span \
class="p">,</span> <span class="n">index</span><span class="p">);</span></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">54</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indentation \
needs to be fixed</pre> </div>
<br />
<p>- Shantanu</p>
<br />
<p>On August 8th, 2013, 2:30 p.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated Aug. 8, 2013, 2:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Folder Contents(Images) are previewed when we browse the local \
directories for Pictures.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. Works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localpictures/CMakeLists.txt <span style="color: \
grey">(2acbd59)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.h <span \
style="color: grey">(d61f2a3)</span></li>
<li>browsingbackends/localfiles/localpictures/localpicturesmodel.cpp <span \
style="color: grey">(afb852f)</span></li>
<li>browsingbackends/localfiles/localthumbnailprovider.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localthumbnailprovider.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localvideos/CMakeLists.txt <span style="color: \
grey">(3cac82c)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.h <span style="color: \
grey">(3b4b668)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideosmodel.cpp <span style="color: \
grey">(6bdf386)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideothumbnailprovider.h <span \
style="color: grey">(d485b11)</span></li>
<li>browsingbackends/localfiles/localvideos/localvideothumbnailprovider.cpp <span \
style="color: grey">(d666ac4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111863/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic