'Re: Review Request 111828: fix link click in notification'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111828: fix link click in notification
From:       "Commit Hook" <null () kde ! org>
Date:       2013-08-01 20:28:25
Message-ID: 20130801202825.16880.20989 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111828/
-----------------------------------------------------------

(Updated Aug. 1, 2013, 8:28 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Marco Martin.

Description
-------

handle the linkActivated signal in both popup and notification history.

now click on link can open browser (or anything it should be) correctly.

Diffs
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml ca7564f 
  plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 29a6a2d 

Diff: http://git.reviewboard.kde.org/r/111828/diff/

Testing
-------

No problem, and seems the drag operation is not affected (if not dragging from link).

test with:
notify-send "<a href="https://google.com">test link</a>"

Thanks,

Xuetian Weng

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111828/">http://git.reviewboard.kde.org/r/111828/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Aug. 1, 2013, 8:28 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">handle the linkActivated signal in both popup and notification history.

now click on link can open browser (or anything it should be) correctly.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No problem, and seems the drag operation is not affected (if not \
dragging from link).

test with:
notify-send &quot;&lt;a href=&quot;https://google.com&quot;&gt;test \
link&lt;/a&gt;&quot;</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(ca7564f)</span></li>

 <li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(29a6a2d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111828/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 