[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111801: Minor fix in Local Browsing Search
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2013-07-30 18:42:33
Message-ID: 20130730184233.17584.57062 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111801/#review36837
-----------------------------------------------------------
Ship it!
mediaelements/mediabrowser/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/111801/#comment27171>
keep opening curly brace in same line to if
if (event.text && searchMedia.visible) {
we follow this convention
mediaelements/mediabrowser/MediaBrowser.qml
<http://git.reviewboard.kde.org/r/111801/#comment27172>
else statement should be written in same line to closing curly brace of if
Syntax:
if (condition) {
// statement
} else {
// statement
}
Works perfectly!
Ship it after fixing these small issues
- Sinny Kumari
On July 30, 2013, 6:12 p.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111801/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 6:12 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Description
> -------
>
> Removed a couple of unnecessary statements in the Local Files Model and fixed the \
> extra white space fault when escape key is pressed in local browsing search.
>
> Diffs
> -----
>
> browsingbackends/localfiles/localfilesabstractbackend.cpp 1f3ac9b
> browsingbackends/localfiles/localfilesabstractmodel.cpp eb797d2
> mediaelements/mediabrowser/MediaBrowser.qml 42e4fa2
>
> Diff: http://git.reviewboard.kde.org/r/111801/diff/
>
>
> Testing
> -------
>
> Yes.
>
> Sinny : Please see if the patch does not ruin the intention of your commit earlier \
> in mediaBrowser and please check if the issue you pointed earlier gets solved.
>
> Thanks,
>
> Akshay Ratan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111801/">http://git.reviewboard.kde.org/r/111801/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111801/diff/2/?file=175509#file175509line247" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/mediabrowser/MediaBrowser.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">247</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">keep \
opening curly brace in same line to if if (event.text && \
searchMedia.visible) {
we follow this convention</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111801/diff/2/?file=175509#file175509line251" \
style="color: black; font-weight: bold; text-decoration: \
underline;">mediaelements/mediabrowser/MediaBrowser.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">251</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span> <span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">else \
statement should be written in same line to closing curly brace of if
Syntax:
if (condition) {
// statement
} else {
// statement
}</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works perfectly!
Ship it after fixing these small issues</pre>
<p>- Sinny</p>
<br />
<p>On July 30th, 2013, 6:12 p.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated July 30, 2013, 6:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed a couple of unnecessary statements in the Local Files Model and \
fixed the extra white space fault when escape key is pressed in local browsing \
search.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes.
Sinny : Please see if the patch does not ruin the intention of your commit earlier in \
mediaBrowser and please check if the issue you pointed earlier gets solved.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(1f3ac9b)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: \
grey">(eb797d2)</span></li>
<li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(42e4fa2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111801/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic