From kde-panel-devel Thu Jul 25 04:57:37 2013 From: "Commit Hook" Date: Thu, 25 Jul 2013 04:57:37 +0000 To: kde-panel-devel Subject: Re: Review Request 111650: Adjust RunnerManager to new ThreadWeaver API using JobPointer Message-Id: <20130725045737.27224.92960 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137472829826977 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3210291176099421683==" --===============3210291176099421683== Content-Type: multipart/alternative; boundary="===============8148691470834194038==" --===============8148691470834194038== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/ ----------------------------------------------------------- (Updated July 25, 2013, 4:57 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks and Plasma. Description ------- ThreadWeaver does not use Job* anymore which made the code compile fail and some connects being wrong. This patch adjusts RunnerManager to also use QSharedPointer instead of FindMatchJob*. It simplifies a few things as we do no longer have to call e.g. qDeleteAll and fixes the incorrect connects. The patch also enables C++11 as it uses auto. Diffs ----- src/plasma/private/runnerjobs.cpp a012a6c src/plasma/private/runnerjobs_p.h cf05324 src/plasma/runnermanager.h ebeb029 src/plasma/runnermanager.cpp 46857f4 Diff: http://git.reviewboard.kde.org/r/111650/diff/ Testing ------- compiles, but couldn't run the unit tests (something is broken in my setup) Thanks, Martin Gräßlin --===============8148691470834194038== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111650/

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

By Martin Gräßlin.

Updated July 25, 2013, 4:57 a.m.

Description

ThreadWeaver does not use Job* anymore which made the code compile fail and some connects being wrong.

This patch adjusts RunnerManager to also use QSharedPointer<FindMatchJob> instead of FindMatchJob*. It
simplifies a few things as we do no longer have to call e.g. qDeleteAll and fixes the incorrect connects.

The patch also enables C++11 as it uses auto.

Testing

compiles, but couldn't run the unit tests (something is broken in my setup)

Diffs

src/plasma/private/runnerjobs.cpp (a012a6c)
src/plasma/private/runnerjobs_p.h (cf05324)
src/plasma/runnermanager.h (ebeb029)
src/plasma/runnermanager.cpp (46857f4)

View Diff

--===============8148691470834194038==-- --===============3210291176099421683== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3210291176099421683==--