'Re: Review Request 111621: Increase size of label pixmap to account for margins and shadows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111621: Increase size of label pixmap to account for margins and shadows
From:       "Commit Hook" <null () kde ! org>
Date:       2013-07-23 10:24:17
Message-ID: 20130723102417.6483.90439 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111621/#review36359
-----------------------------------------------------------

This review has been submitted with commit e73da75872b952a3c17d50748fdfe7445a1ee020 \
by Christoph Feck to branch KDE/4.11.

- Commit Hook

On July 20, 2013, 4:53 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111621/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 4:53 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> The text label is rendered into a pixmap which can be smaller than the actual text, \
> because the item rect is inside some margins. 
> This patch does two things:
> - increase the pixmap size by 4 pixels on top and bottom
> - fix the text positioning
> 
> 
> This addresses bug 314879.
> http://bugs.kde.org/show_bug.cgi?id=314879
> 
> 
> Diffs
> -----
> 
> plasma/desktop/applets/tasks/support/textlabel.cpp 9fbc12d 
> 
> Diff: http://git.reviewboard.kde.org/r/111621/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111621/">http://git.reviewboard.kde.org/r/111621/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit e73da75872b952a3c17d50748fdfe7445a1ee020 by Christoph Feck to \
branch KDE/4.11.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 20th, 2013, 4:53 p.m. UTC, Christoph Feck wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Eike Hein.</div>
<div>By Christoph Feck.</div>

<p style="color: grey;"><i>Updated July 20, 2013, 4:53 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The text label is rendered into a pixmap which can be smaller than the \
actual text, because the item rect is inside some margins.

This patch does two things:
- increase the pixmap size by 4 pixels on top and bottom
- fix the text positioning
</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314879">314879</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/tasks/support/textlabel.cpp <span style="color: \
grey">(9fbc12d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111621/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 