'Re: Review Request 111614: Fix Key Navigation in Plasma Media Center'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111614: Fix Key Navigation in Plasma Media Center
From:       "Commit Hook" <null () kde ! org>
Date:       2013-07-21 9:38:55
Message-ID: 20130721093855.16954.21313 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111614/#review36233
-----------------------------------------------------------

This review has been submitted with commit 30c0a4bbbf8a3112cbe53b09a22d3b2879ca935d \
by Akshay Ratan to branch master.

- Commit Hook

On July 20, 2013, 10:03 a.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111614/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 10:03 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
> 
> 
> Description
> -------
> 
> This single line patch aims to fix the broken key navigation possibly due to \
> revision 0d028a8a7f0d5edf99a5411b9f0c8ce69bdd4bf4 , keeping in place the changes \
> made by the mentioned revision. 
> 
> Diffs
> -----
> 
> mediaelements/mediabrowser/MediaBrowser.qml 5cccb12 
> 
> Diff: http://git.reviewboard.kde.org/r/111614/diff/
> 
> 
> Testing
> -------
> 
> The key navigation does not break now.
> 
> Sinny : Please check once if the changes you intended from that patch are there. 
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111614/">http://git.reviewboard.kde.org/r/111614/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 30c0a4bbbf8a3112cbe53b09a22d3b2879ca935d by Akshay Ratan to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On July 20th, 2013, 10:03 a.m. UTC, Akshay Ratan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>

<p style="color: grey;"><i>Updated July 20, 2013, 10:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This single line patch aims to fix the broken key navigation possibly \
due to revision 0d028a8a7f0d5edf99a5411b9f0c8ce69bdd4bf4 , keeping in place the \
changes made by the mentioned revision.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The key navigation does not break now.

Sinny : Please check once if the changes you intended from that patch are there. \
</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(5cccb12)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111614/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 