'Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111337: Enhancements and optimization in navigation flow of Plasma Media Center
From:       "Commit Hook" <null () kde ! org>
Date:       2013-07-03 17:04:16
Message-ID: 20130703170416.15309.69579 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111337/
-----------------------------------------------------------

(Updated July 3, 2013, 5:04 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar, Sinny Kumari, Sujith Haridasan, and \
Thomas Pfeiffer.

Description
-------

This patch aims to enhance the file-browsing capability and navigation in the \
plasma-mediacenter. Implemented a stack to store the browsing URLs and thus ensure \
that the user can select another drive by coming to the PLACE MODEL screen on \
pressing escape/back required number of times. Further, earlier on clicking BROWSE \
Pics/Music/Videos , PMC took us to the last browsing folder but now we get back to \
the PLACE MODEL screen on clicking it which is more convenient for the user as he/she \
has all the options again to browse whatever drive they want to.

Diffs
-----

  browsingbackends/localfiles/localfilesabstractbackend.cpp 33ea4ef 
  browsingbackends/localfiles/localfilesabstractmodel.cpp a02e65d 

Diff: http://git.reviewboard.kde.org/r/111337/diff/

Testing
-------

Yes, works as intended.

However there seems to be one small glitch::
Steps to reproduce---
1) Select a drive from PLACES MODEL screen eg FOO
2) Select a folder eg BAR
3) Select a folder inside again eg BAR2 . Now press escape/back, you will \
successfully go one level back to BAR. 4) Now try pressing ESCAPE/BACK, ideally \
PLACES MODEL Screen should be shown , but you will notice, you have to press 2 \
escape/back keys to go there.

Rest all works as intended and NO application crashes were experienced.

Thanks,

Akshay Ratan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111337/">http://git.reviewboard.kde.org/r/111337/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, Sujith Haridasan, and \
Thomas Pfeiffer.</div> <div>By Akshay Ratan.</div>

<p style="color: grey;"><i>Updated July 3, 2013, 5:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch aims to enhance the file-browsing capability and navigation \
in the plasma-mediacenter. Implemented a stack to store the browsing URLs and thus \
ensure that the user can select another drive by coming to the PLACE MODEL screen on \
pressing escape/back required number of times. Further, earlier on clicking BROWSE \
Pics/Music/Videos , PMC took us to the last browsing folder but now we get back to \
the PLACE MODEL screen on clicking it which is more convenient for the user as he/she \
has all the options again to browse whatever drive they want to.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, works as intended.

However there seems to be one small glitch::
Steps to reproduce---
1) Select a drive from PLACES MODEL screen eg FOO
2) Select a folder eg BAR
3) Select a folder inside again eg BAR2 . Now press escape/back, you will \
successfully go one level back to BAR. 4) Now try pressing ESCAPE/BACK, ideally \
PLACES MODEL Screen should be shown , but you will notice, you have to press 2 \
escape/back keys to go there.

Rest all works as intended and NO application crashes were experienced.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(33ea4ef)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: \
grey">(a02e65d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111337/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 