--===============5682537103314652676== Content-Type: multipart/alternative; boundary="===============1164455166537541920==" --===============1164455166537541920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/ ----------------------------------------------------------- (Updated June 28, 2013, 5:11 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Description ------- Steps to reproduce the earlier error : 1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in plasma-mediacenter Homescreen 2) Press Escape Key when the "PLACE screen" or initial browsing window having various drives appears. Don't select anything, just press escape intending to go back to the homescreen. 3) Result:: PMC Application crashes However BACK button on the toolbar works fine. This patch aims to solve this issue in escape key functioning. Shantanu: However, after applying this patch, as you will notice, escape key in the same scenario mentioned in Step 2 , would take the user back "by one level" and NOT to the homescreen. Please see if this is the behaviour required. Diffs ----- browsingbackends/localfiles/localfilesabstractbackend.cpp 31ada99 Diff: http://git.reviewboard.kde.org/r/111287/diff/ Testing ------- Yes. Application does not crash now in the scenario mentioned :) Thanks, Akshay Ratan --===============1164455166537541920== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111287/

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.

By Akshay Ratan.

Updated June 28, 2013, 5:11 p.m.

Description

Steps to reproduce the earlier error :

1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in plasma-mediacenter Homescreen
2) Press Escape Key when the "PLACE screen" or initial browsing window having various drives appears. Don't select anything, just press escape intending to go    back to the homescreen.
3) Result:: PMC Application crashes 

However BACK button on the toolbar works fine.

This patch aims to solve this issue in escape key functioning. 

Shantanu: However, after applying this patch, as you will notice, escape key in the same scenario mentioned in Step 2 , would take the user back "by one level" and NOT to the homescreen. Please see if this is the behaviour required.

Testing

Yes. Application does not crash now in the scenario mentioned :)

Diffs

browsingbackends/localfiles/localfilesabstractbackend.cpp (31ada99)

--===============1164455166537541920==-- --===============5682537103314652676== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5682537103314652676==--