[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111287: Fix of an issue in Escape Key functioning
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-06-28 16:51:28
Message-ID: 20130628165128.15718.27894 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111287/#review35241
-----------------------------------------------------------
Ship it!
Ship It!
- Shantanu Tushar
On June 28, 2013, 7:51 a.m., Akshay Ratan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111287/
> -----------------------------------------------------------
>
> (Updated June 28, 2013, 7:51 a.m.)
>
>
> Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan.
>
>
> Description
> -------
>
> Steps to reproduce the earlier error :
>
> 1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in \
> plasma-mediacenter Homescreen 2) Press Escape Key when the "PLACE screen" or \
> initial browsing window having various drives appears. Don't select anything, just \
> press escape intending to go back to the homescreen. 3) Result:: PMC Application \
> crashes
> However BACK button on the toolbar works fine.
>
> This patch aims to solve this issue in escape key functioning.
>
> Shantanu: However, after applying this patch, as you will notice, escape key in the \
> same scenario mentioned in Step 2 , would take the user back "by one level" and NOT \
> to the homescreen. Please see if this is the behaviour required.
>
> Diffs
> -----
>
> browsingbackends/localfiles/localfilesabstractbackend.cpp 31ada99
>
> Diff: http://git.reviewboard.kde.org/r/111287/diff/
>
>
> Testing
> -------
>
> Yes. Application does not crash now in the scenario mentioned :)
>
>
> Thanks,
>
> Akshay Ratan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111287/">http://git.reviewboard.kde.org/r/111287/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Shantanu</p>
<br />
<p>On June 28th, 2013, 7:51 a.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith \
Haridasan.</div> <div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated June 28, 2013, 7:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Steps to reproduce the earlier error :
1) Select the BROWSE PICTURES/MUSIC/VIDEO option from the categories in \
plasma-mediacenter Homescreen 2) Press Escape Key when the "PLACE screen" \
or initial browsing window having various drives appears. Don't select anything, \
just press escape intending to go back to the homescreen. 3) Result:: PMC \
Application crashes
However BACK button on the toolbar works fine.
This patch aims to solve this issue in escape key functioning.
Shantanu: However, after applying this patch, as you will notice, escape key in the \
same scenario mentioned in Step 2 , would take the user back "by one level" \
and NOT to the homescreen. Please see if this is the behaviour required. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes. Application does not crash now in the scenario mentioned :)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(31ada99)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111287/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic