[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter
From: "Commit Hook" <null () kde ! org>
Date: 2013-06-27 18:16:07
Message-ID: 20130627181607.28046.61324 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111263/
-----------------------------------------------------------
(Updated June 27, 2013, 6:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.
Description
-------
The File explorer/browser in the plasma-mediacenter has been revamped. The side-panel \
has been removed. Now the drives and other system directories appears on clicking \
"Browse Pics/Music/Videos" instead of "home" folder contents appeaaring earlier after \
selecting this particular option.
Diffs
-----
browsingbackends/localfiles/localfilesabstractbackend.h b7cc909
browsingbackends/localfiles/localfilesabstractbackend.cpp 5768fb3
browsingbackends/localfiles/localfilesabstractmodel.h c4c8be3
browsingbackends/localfiles/localfilesabstractmodel.cpp 6c66b43
browsingbackends/localfiles/localmusic/CMakeLists.txt 4b804ae
browsingbackends/localfiles/localpictures/CMakeLists.txt c7ba5fa
browsingbackends/localfiles/localplacesmodel.h PRE-CREATION
browsingbackends/localfiles/localplacesmodel.cpp PRE-CREATION
browsingbackends/localfiles/localvideos/CMakeLists.txt 15677d7
Diff: http://git.reviewboard.kde.org/r/111263/diff/
Testing
-------
Major things working fine , but there might be certain issues regarding the correct \
folder contents shown inside any folder in any particular directory.
Further malformed url might appear on clicking certain drives. However this can be \
fixed later :)
Thanks,
Akshay Ratan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111263/">http://git.reviewboard.kde.org/r/111263/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 6:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The File explorer/browser in the plasma-mediacenter has been revamped. \
The side-panel has been removed. Now the drives and other system directories appears \
on clicking "Browse Pics/Music/Videos" instead of "home" folder \
contents appeaaring earlier after selecting this particular option. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Major things working fine , but there might be certain issues regarding \
the correct folder contents shown inside any folder in any particular directory.
Further malformed url might appear on clicking certain drives. However this can be \
fixed later :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/localfiles/localfilesabstractbackend.h <span style="color: \
grey">(b7cc909)</span></li>
<li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(5768fb3)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.h <span style="color: \
grey">(c4c8be3)</span></li>
<li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: \
grey">(6c66b43)</span></li>
<li>browsingbackends/localfiles/localmusic/CMakeLists.txt <span style="color: \
grey">(4b804ae)</span></li>
<li>browsingbackends/localfiles/localpictures/CMakeLists.txt <span style="color: \
grey">(c7ba5fa)</span></li>
<li>browsingbackends/localfiles/localplacesmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localplacesmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/localfiles/localvideos/CMakeLists.txt <span style="color: \
grey">(15677d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111263/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic