'Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111263: Revamping the filesystem browser in the plasma-mediacenter
From:       "Shantanu Tushar" <shantanu () kde ! org>
Date:       2013-06-27 15:16:07
Message-ID: 20130627151607.24847.61254 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111263/#review35174
-----------------------------------------------------------

looks good, just fix these issues

browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25757>

    Remove this before pushing

browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25758>

    KDE/KUrl, for consistency

browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25755>

    variable names should tell you what they represent. In this case, m_expand = true \
means placesModel is not being shown.  Ideally, you should reverse the logic and call \
the variable m_isShowingPlacesModel. (So all your true's will become false's and \
vice-versa)

browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25756>

    Remove the qDebug() before pushing

browsingbackends/localfiles/localfilesabstractbackend.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25754>

    m_placesModel, plural

browsingbackends/localfiles/localfilesabstractmodel.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25759>

    combine these into a single return statement

browsingbackends/localfiles/localplacesmodel.cpp
<http://git.reviewboard.kde.org/r/111263/#comment25760>

    placesModel, plural

- Shantanu Tushar

On June 26, 2013, 7:22 p.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111263/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 7:22 p.m.)
> 
> 
> Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and \
> Sujith Haridasan. 
> 
> Description
> -------
> 
> The File explorer/browser in the plasma-mediacenter has been revamped. The \
> side-panel has been removed. Now the drives and other system directories appears on \
> clicking "Browse Pics/Music/Videos" instead of "home" folder contents appeaaring \
> earlier after selecting this particular option.  
> 
> Diffs
> -----
> 
> browsingbackends/localfiles/localfilesabstractbackend.h b7cc909 
> browsingbackends/localfiles/localfilesabstractbackend.cpp 5768fb3 
> browsingbackends/localfiles/localfilesabstractmodel.h c4c8be3 
> browsingbackends/localfiles/localfilesabstractmodel.cpp 6c66b43 
> browsingbackends/localfiles/localmusic/CMakeLists.txt 4b804ae 
> browsingbackends/localfiles/localpictures/CMakeLists.txt c7ba5fa 
> browsingbackends/localfiles/localplacesmodel.h PRE-CREATION 
> browsingbackends/localfiles/localplacesmodel.cpp PRE-CREATION 
> browsingbackends/localfiles/localvideos/CMakeLists.txt 15677d7 
> 
> Diff: http://git.reviewboard.kde.org/r/111263/diff/
> 
> 
> Testing
> -------
> 
> Major things working fine , but there might be certain issues regarding the correct \
> folder contents shown inside any folder in any particular directory. 
> Further malformed url might appear on clicking certain drives. However this can be \
> fixed later :) 
> 
> Thanks,
> 
> Akshay Ratan
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111263/">http://git.reviewboard.kde.org/r/111263/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">looks good, just fix \
these issues</pre>  <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165946#file165946line28" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;QDebug&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove this \
before pushing</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165946#file165946line29" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#include &lt;KUrl&gt;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KDE/KUrl, \
for consistency</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165946#file165946line36" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">29</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">36</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">m_expand</span><span class="o">=</span><span class="nb">true</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">variable \
names should tell you what they represent. In this case, m_expand = true means \
placesModel is not being shown. Ideally, you should reverse the logic and call the \
variable m_isShowingPlacesModel. (So all your true&#39;s will become false&#39;s and \
vice-versa)</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165946#file165946line67" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
LocalFilesAbstractBackend::goOneLevelUp()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">qDebug</span><span class="p">()</span> <span class="o">&lt;&lt;</span> \
<span class="n">url</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove the \
qDebug() before pushing</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165946#file165946line76" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractbackend.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QObject* LocalFilesAbstractBackend::placesModel()</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">63</font></th>  <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span> \
<span class="p">(</span><span class="o">!</span><span \
class="n">m_placeModel</span><span class="p">)</span> <span \
class="p">{</span></pre></td>  <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">76</font></th>  <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; ">    <span class="k">if</span> <span \
class="p">(</span><span class="o">!</span><span class="n">m_placeModel</span><span \
class="p">)</span> <span class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">m_placesModel, plural</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165948#file165948line100" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localfilesabstractmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
LocalFilesAbstractModel::browseTo (int row)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">d</span><span class="o">-&gt;</span><span class="n">dirModel</span><span \
class="p">.</span><span class="n">dirLister</span><span class="p">()</span><span \
class="o">-&gt;</span><span class="n">openUrl</span><span class="p">(</span><span \
class="n">url</span><span class="p">);</span></pre></td>  <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">100</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="kt"><span \
class="hl">bool</span></span><span class="hl"> </span><span class="n"><span \
class="hl">browse</span></span><span class="o"><span class="hl">=</span></span><span \
class="n">d</span><span class="o">-&gt;</span><span class="n">dirModel</span><span \
class="p">.</span><span class="n">dirLister</span><span class="p">()</span><span \
class="o">-&gt;</span><span class="n">openUrl</span><span class="p">(</span><span \
class="n">url</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">return</span> <span class="n">browse</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">combine \
these into a single return statement</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/111263/diff/2/?file=165952#file165952line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/localfiles/localplacesmodel.cpp</a>  <span \
style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">KFilePlacesModel</span> <span class="n">placeModel</span><span \
class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">placesModel, plural</pre> </div>
<br />

<p>- Shantanu</p>

<br />
<p>On June 26th, 2013, 7:22 p.m. UTC, Akshay Ratan wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Fabian Riethmayer, Shantanu Tushar, Sinny Kumari, and \
Sujith Haridasan.</div> <div>By Akshay Ratan.</div>

<p style="color: grey;"><i>Updated June 26, 2013, 7:22 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The File explorer/browser in the plasma-mediacenter has been revamped. \
The side-panel has been removed. Now the drives and other system directories appears \
on clicking &quot;Browse Pics/Music/Videos&quot; instead of &quot;home&quot; folder \
contents appeaaring earlier after selecting this particular option. </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Major things working fine , but there might be certain issues regarding \
the correct folder contents shown inside any folder in any particular directory.

Further malformed url might appear on clicking certain drives. However this can be \
fixed later :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>browsingbackends/localfiles/localfilesabstractbackend.h <span style="color: \
grey">(b7cc909)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractbackend.cpp <span style="color: \
grey">(5768fb3)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractmodel.h <span style="color: \
grey">(c4c8be3)</span></li>

 <li>browsingbackends/localfiles/localfilesabstractmodel.cpp <span style="color: \
grey">(6c66b43)</span></li>

 <li>browsingbackends/localfiles/localmusic/CMakeLists.txt <span style="color: \
grey">(4b804ae)</span></li>

 <li>browsingbackends/localfiles/localpictures/CMakeLists.txt <span style="color: \
grey">(c7ba5fa)</span></li>

 <li>browsingbackends/localfiles/localplacesmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>browsingbackends/localfiles/localplacesmodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>browsingbackends/localfiles/localvideos/CMakeLists.txt <span style="color: \
grey">(15677d7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111263/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 