'Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-06-22 15:24:27
Message-ID: 20130622152427.1420.10815 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111148/#review34881
-----------------------------------------------------------

Ship it!

For absolute completeness, the sortCaseSensitivity property should also have a NOTIFY \
signal .. but i don't see why anyone would ever bind to that signal and it would \
require a reimplementation of the set method, so i'm fine with it going in without .. \
so a +1 from me; if Marco can confirm then this is good to go in.

- Aaron J. Seigo

On June 22, 2013, 2:42 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111148/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 2:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to \
> the PlasmaCore.SortFilterModel. Allows to sort items case insensitive. 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/core/datamodel.h 0943b68 
> plasma/declarativeimports/core/datamodel.cpp f81e579 
> 
> Diff: http://git.reviewboard.kde.org/r/111148/diff/
> 
> 
> Testing
> -------
> 
> Tested with the battery monitor. Now "eva" comes before "Logitech" :)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111148/">http://git.reviewboard.kde.org/r/111148/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For absolute \
completeness, the sortCaseSensitivity property should also have a NOTIFY signal .. \
but i don&#39;t see why anyone would ever bind to that signal and it would require a \
reimplementation of the set method, so i&#39;m fine with it going in without .. so a \
+1 from me; if Marco can confirm then this is good to go in.</pre>  <br />

<p>- Aaron J.</p>

<br />
<p>On June 22nd, 2013, 2:42 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated June 22, 2013, 2:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds support for the sortCaseSensitivity property of \
QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case \
insensitive.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the battery monitor. Now &quot;eva&quot; comes before \
&quot;Logitech&quot; :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/datamodel.h <span style="color: \
grey">(0943b68)</span></li>

 <li>plasma/declarativeimports/core/datamodel.cpp <span style="color: \
grey">(f81e579)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111148/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 