[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111047: Handle edge cases when going back/escape
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2013-06-20 18:53:24
Message-ID: 20130620185324.7416.94201 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/#review34797
-----------------------------------------------------------
Ship it!
Still whatever I mentioned is broken.
For now, I will suggest ship diff r2 because it handle all major cases. \
Remaining cases we can handle when we re-write keyboard navigation stuff.
- Sinny Kumari
On June 20, 2013, 12:19 p.m., Shantanu Tushar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111047/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 12:19 p.m.)
>
>
> Review request for Plasma, Akshay Ratan and Sinny Kumari.
>
>
> Description
> -------
>
> At places we assume that there always be a valid browsing backend. In \
> many situations this isn't true, which is exactly what this patch \
> handles.
>
> Diffs
> -----
>
> mediaelements/mediabrowser/MediaBrowser.qml e7aa109
> shells/newshell/package/contents/ui/mediacenter.qml d533b60
>
> Diff: http://git.reviewboard.kde.org/r/111047/diff/
>
>
> Testing
> -------
>
> Tested some scenarios that I could think of. Please test few scenarios \
> and see if this works.
> Akshay: I think the new if conditions make previousBackend necessary, \
> please check that your feature still works fine.
>
> Thanks,
>
> Shantanu Tushar
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111047/">http://git.reviewboard.kde.org/r/111047/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Still whatever I mentioned is broken. For now, I will suggest \
ship diff r2 because it handle all major cases. Remaining cases we can \
handle when we re-write keyboard navigation stuff.</pre> <br />
<p>- Sinny</p>
<br />
<p>On June 20th, 2013, 12:19 p.m. UTC, Shantanu Tushar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma, Akshay Ratan and Sinny Kumari.</div>
<div>By Shantanu Tushar.</div>
<p style="color: grey;"><i>Updated June 20, 2013, 12:19 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">At places we assume that there always be a valid browsing \
backend. In many situations this isn't true, which is exactly what this \
patch handles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested some scenarios that I could think of. Please test few \
scenarios and see if this works.
Akshay: I think the new if conditions make previousBackend necessary, \
please check that your feature still works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(e7aa109)</span></li>
<li>shells/newshell/package/contents/ui/mediacenter.qml <span \
style="color: grey">(d533b60)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111047/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic