[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111148: Add support for sortCaseSensitivity in SortFilterModel
From: "Marco Martin" <notmart () gmail ! com>
Date: 2013-06-20 9:46:50
Message-ID: 20130620094650.25364.63938 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 20, 2013, 9:20 a.m., Aaron J. Seigo wrote:
> > plasma/declarativeimports/core/datamodel.h, line 94
> > <http://git.reviewboard.kde.org/r/111148/diff/1/?file=164874#file164874line94>
> >
> > is this necessary, given that there is a setSortCaseSensitivity in the parent \
> > class?
you can bind qproperty read and write on superclass methods as well.
one reason it might be necessary is because you want also a notify signal when it \
changes (so property bindings can work) so you can emit the signal when you set the \
property
another way could be rechecking the sort property when the model gets reset, so the \
signal can be emitted there...
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111148/#review34738
-----------------------------------------------------------
On June 20, 2013, 9:41 a.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111148/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:41 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This adds support for the sortCaseSensitivity property of QSortFilterProxyModel to \
> the PlasmaCore.SortFilterModel. Allows to sort items case insensitive.
>
> Diffs
> -----
>
> plasma/declarativeimports/core/datamodel.h 0943b68
>
> Diff: http://git.reviewboard.kde.org/r/111148/diff/
>
>
> Testing
> -------
>
> Tested with the battery monitor. Now "eva" comes before "Logitech" :)
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111148/">http://git.reviewboard.kde.org/r/111148/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 20th, 2013, 9:20 a.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111148/diff/1/?file=164874#file164874line94" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/declarativeimports/core/datamodel.h</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">94</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="nf">setSortCaseSensitivity</span><span \
class="p">(</span><span class="k">const</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">CaseSensitivity</span> <span \
class="n">sensitivity</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is this necessary, given \
that there is a setSortCaseSensitivity in the parent class?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can \
bind qproperty read and write on superclass methods as well. one reason it might be \
necessary is because you want also a notify signal when it changes (so property \
bindings can work) so you can emit the signal when you set the property
another way could be rechecking the sort property when the model gets reset, so the \
signal can be emitted there...</pre> <br />
<p>- Marco</p>
<br />
<p>On June 20th, 2013, 9:41 a.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated June 20, 2013, 9:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds support for the sortCaseSensitivity property of \
QSortFilterProxyModel to the PlasmaCore.SortFilterModel. Allows to sort items case \
insensitive.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with the battery monitor. Now "eva" comes before \
"Logitech" :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/declarativeimports/core/datamodel.h <span style="color: \
grey">(0943b68)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111148/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic