'Re: Review Request 111047: Handle edge cases when going back/escape'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111047: Handle edge cases when going back/escape
From:       "Shantanu Tushar" <shantanu () kde ! org>
Date:       2013-06-19 18:00:54
Message-ID: 20130619180054.23490.78058 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/
-----------------------------------------------------------

(Updated June 19, 2013, 6 p.m.)

Review request for Plasma, Akshay Ratan and Sinny Kumari.

Changes
-------

Now when you click on empty space, media browser will be initialized. However, \
pressing escape will still directly take you to home screen. You can get the media \
browser by clicking on the browser button at the top.

Description
-------

At places we assume that there always be a valid browsing backend. In many situations \
this isn't true, which is exactly what this patch handles.

Diffs (updated)
-----

  mediaelements/mediabrowser/MediaBrowser.qml e7aa109 
  shells/newshell/package/contents/ui/mediacenter.qml d533b60 

Diff: http://git.reviewboard.kde.org/r/111047/diff/

Testing
-------

Tested some scenarios that I could think of. Please test few scenarios and see if \
                this works.
Akshay: I think the new if conditions make previousBackend necessary, please check \
that your feature still works fine.

Thanks,

Shantanu Tushar

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111047/">http://git.reviewboard.kde.org/r/111047/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Akshay Ratan and Sinny Kumari.</div>
<div>By Shantanu Tushar.</div>

<p style="color: grey;"><i>Updated June 19, 2013, 6 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now when you click on empty space, media browser will be initialized. \
However, pressing escape will still directly take you to home screen. You can get the \
media browser by clicking on the browser button at the top.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">At places we assume that there always be a valid browsing backend. In \
many situations this isn&#39;t true, which is exactly what this patch handles.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested some scenarios that I could think of. Please test few scenarios \
                and see if this works.
Akshay: I think the new if conditions make previousBackend necessary, please check \
that your feature still works fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: \
grey">(e7aa109)</span></li>

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(d533b60)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111047/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 