[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111035: Merging sinny-youtube branch to master
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-06-15 18:26:59
Message-ID: 20130615182659.15733.9711 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111035/#review34391
-----------------------------------------------------------
Ship it!
Good to go to master, just fix this one before pushing
browsingbackends/onlineservices/youtube/videodetailsmodel.h
<http://git.reviewboard.kde.org/r/111035/#comment25265>
even this would be const ref
- Shantanu Tushar
On June 15, 2013, 6:15 p.m., Sinny Kumari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111035/
> -----------------------------------------------------------
>
> (Updated June 15, 2013, 6:15 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Support of watching youtube video has been added in branch sinny-youtube. \
> Currently, it contains features: 1. Search for youtube video
> 2. Play selected video
> 3. Other basic functionalities like play, pause, seek, etc currently playing video
>
>
> Diffs
> -----
>
> browsingbackends/onlineservices/CMakeLists.txt 860e2a4
> browsingbackends/onlineservices/youtube/CMakeLists.txt PRE-CREATION
> browsingbackends/onlineservices/youtube/constants.h PRE-CREATION
> browsingbackends/onlineservices/youtube/diskcache.h PRE-CREATION
> browsingbackends/onlineservices/youtube/diskcache.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/global.h PRE-CREATION
> browsingbackends/onlineservices/youtube/networkaccess.h PRE-CREATION
> browsingbackends/onlineservices/youtube/networkaccess.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/video.h PRE-CREATION
> browsingbackends/onlineservices/youtube/video.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/videodefinition.h PRE-CREATION
> browsingbackends/onlineservices/youtube/videodefinition.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/videodetailsmodel.h PRE-CREATION
> browsingbackends/onlineservices/youtube/videodetailsmodel.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/youtubebackend.h PRE-CREATION
> browsingbackends/onlineservices/youtube/youtubebackend.cpp PRE-CREATION
> browsingbackends/onlineservices/youtube/youtubebackend.desktop PRE-CREATION
> browsingbackends/onlineservices/youtube/youtubemodel.h PRE-CREATION
> browsingbackends/onlineservices/youtube/youtubemodel.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/111035/diff/
>
>
> Testing
> -------
>
> Works fine
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_2.png
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_1.png
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play_1.png
>
>
> Thanks,
>
> Sinny Kumari
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111035/">http://git.reviewboard.kde.org/r/111035/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good to go to master, \
just fix this one before pushing</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/111035/diff/2/?file=150616#file150616line43" \
style="color: black; font-weight: bold; text-decoration: \
underline;">browsingbackends/onlineservices/youtube/videodetailsmodel.h</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">43</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="kt">void</span> <span class="n">streamUrl</span><span class="p">(</span><span \
class="n">QUrl</span> <span class="n">url</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">even this \
would be const ref</pre> </div>
<br />
<p>- Shantanu</p>
<br />
<p>On June 15th, 2013, 6:15 p.m. UTC, Sinny Kumari wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated June 15, 2013, 6:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support of watching youtube video has been added in branch \
sinny-youtube. Currently, it contains features: 1. Search for youtube video
2. Play selected video
3. Other basic functionalities like play, pause, seek, etc currently playing \
video</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/onlineservices/CMakeLists.txt <span style="color: \
grey">(860e2a4)</span></li>
<li>browsingbackends/onlineservices/youtube/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/constants.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/diskcache.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/diskcache.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/global.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/networkaccess.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/networkaccess.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/video.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/video.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodefinition.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodefinition.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodetailsmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodetailsmodel.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111035/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_2.png">youtube_browser_2.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_1.png">youtube_selected_video_1.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play_1.png">youtube_selected_video_play_1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic