[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 111034: Merging sinny-youtube branch to master
From: "Sinny Kumari" <ksinny () gmail ! com>
Date: 2013-06-15 5:25:12
Message-ID: 20130615052512.21049.91857 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111034/
-----------------------------------------------------------
(Updated June 15, 2013, 5:25 a.m.)
Review request for Plasma.
Changes
-------
Replacing snapshot
Description
-------
Support of watching youtube video has be added in branch sinny-youtube. Currently, it contains features:
1. Search for youtube video
2. Play selected video
3. Other basic functionalities like play, pause, seek, etc currently playing video
Diffs
-----
browsingbackends/onlineservices/CMakeLists.txt 860e2a4
browsingbackends/onlineservices/youtube/CMakeLists.txt PRE-CREATION
browsingbackends/onlineservices/youtube/constants.h PRE-CREATION
browsingbackends/onlineservices/youtube/diskcache.h PRE-CREATION
browsingbackends/onlineservices/youtube/diskcache.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/global.h PRE-CREATION
browsingbackends/onlineservices/youtube/networkaccess.h PRE-CREATION
browsingbackends/onlineservices/youtube/networkaccess.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/video.h PRE-CREATION
browsingbackends/onlineservices/youtube/video.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/videodefinition.h PRE-CREATION
browsingbackends/onlineservices/youtube/videodefinition.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/videodetailsmodel.h PRE-CREATION
browsingbackends/onlineservices/youtube/videodetailsmodel.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/youtubebackend.h PRE-CREATION
browsingbackends/onlineservices/youtube/youtubebackend.cpp PRE-CREATION
browsingbackends/onlineservices/youtube/youtubebackend.desktop PRE-CREATION
browsingbackends/onlineservices/youtube/youtubemodel.h PRE-CREATION
browsingbackends/onlineservices/youtube/youtubemodel.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/111034/diff/
Testing
-------
Works fine
File Attachments (updated)
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play.png
http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_1.png
Thanks,
Sinny Kumari
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111034/">http://git.reviewboard.kde.org/r/111034/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sinny Kumari.</div>
<p style="color: grey;"><i>Updated June 15, 2013, 5:25 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replacing snapshot</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Support of watching youtube video has be added in branch sinny-youtube. \
Currently, it contains features: 1. Search for youtube video
2. Play selected video
3. Other basic functionalities like play, pause, seek, etc currently playing \
video</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works fine</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>browsingbackends/onlineservices/CMakeLists.txt <span style="color: \
grey">(860e2a4)</span></li>
<li>browsingbackends/onlineservices/youtube/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/constants.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/diskcache.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/diskcache.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/global.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/networkaccess.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/networkaccess.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/video.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/video.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodefinition.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodefinition.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodetailsmodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/videodetailsmodel.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubebackend.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubemodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>browsingbackends/onlineservices/youtube/youtubemodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111034/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video.png">youtube_selected_video.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_selected_video_play.png">youtube_selected_video_play.png</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/06/15/youtube_browser_1.png">youtube_browser_1.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic