'Re: Review Request 111006: Escape Key fix in the media player'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 111006: Escape Key fix in the media player
From:       "Commit Hook" <null () kde ! org>
Date:       2013-06-14 19:47:49
Message-ID: 20130614194749.29158.23941 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111006/
-----------------------------------------------------------

(Updated June 14, 2013, 7:47 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

Description
-------

Steps to reproduce the existing error-

Open a video in the Plasma Media Center.
Navigate to main screen and click the empty screen to go back to the media
Video again opens, now try pressing escape key to realize that there is no option to go back.

A couple of line patch to fix this ensuring Escape Key works as required in the media player.

Diffs
-----

  shells/newshell/package/contents/ui/mediacenter.qml d56344d 

Diff: http://git.reviewboard.kde.org/r/111006/diff/

Testing
-------

Works as intended.

Thanks,

Akshay Ratan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111006/">http://git.reviewboard.kde.org/r/111006/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>

<p style="color: grey;"><i>Updated June 14, 2013, 7:47 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Steps to reproduce the existing error-

Open a video in the Plasma Media Center.
Navigate to main screen and click the empty screen to go back to the media
Video again opens, now try pressing escape key to realize that there is no option to \
go back.

A couple of line patch to fix this ensuring Escape Key works as required in the media \
player.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as intended.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(d56344d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111006/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 