[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request 111017: Fix:Playlist Entries swap
From: "Akshay Ratan" <akshay_ratan () yahoo ! com>
Date: 2013-06-14 7:15:09
Message-ID: 20130614071509.5300.54845 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111017/
-----------------------------------------------------------
Review request for Plasma, Shantanu Tushar and Sinny Kumari.
Description
-------
Earlier user had to do Press and Hold the playlist entries to enable swapping of \
playlist items feature by dragging. This single line patch aims to make it more \
convenient. Now user just has to press the playlist item and drag it to swap with \
other. This becomes even more intuitive as the case should be with a media \
application.
Besides, 2 lines have be removed as they were not really important.
Diffs
-----
mediaelements/playlist/PlaylistDelegate.qml a2b4fae
Diff: http://git.reviewboard.kde.org/r/111017/diff/
Testing
-------
Yes
Thanks,
Akshay Ratan
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111017/">http://git.reviewboard.kde.org/r/111017/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Earlier user had to do Press and Hold the playlist entries to enable \
swapping of playlist items feature by dragging. This single line patch aims to make \
it more convenient. Now user just has to press the playlist item and drag it to swap \
with other. This becomes even more intuitive as the case should be with a media \
application.
Besides, 2 lines have be removed as they were not really important.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/playlist/PlaylistDelegate.qml <span style="color: \
grey">(a2b4fae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111017/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic