[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly
From: Akshay Ratan <akshayratan () gmail ! com>
Date: 2013-06-12 9:19:40
Message-ID: CAKTp-8R0ipedjtu1vHABFfm4t8tx22ZYOW_W_arFw1gr7GNijg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Sebastian,
I know, pretty minor changes are needed in this. I was on some other task,
but nevertheless, I l do this as soon as possible . Thanks for the reminder
though :)
Regards,
Akshay
On Wed, Jun 12, 2013 at 1:50 PM, Sebastian Kügler <sebas@kde.org> wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110629/
>
> This has been lingering for two weeks, yet the changes needed are pretty simple: \
> Akshay, is this still on your radar?
>
> - Sebastian
>
> On May 24th, 2013, 7:46 a.m. UTC, Akshay Ratan wrote:
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> By Akshay Ratan.
>
> *Updated May 24, 2013, 7:46 a.m.*
> Description
>
> Dimming the image when it is not viewed directly or more simply when it shows up in \
> background while navigating in the Plasma Media Center.
> The existing minor problem was that when user views a picture in a slideshow and \
> then navigate to the main screen or one level up, the image is shown in the same \
> opacity as the original in the background which causes a little discomfort in \
> seeing the gallery and other written texts on screen.
> Testing
>
> Works as intended.
>
> Diffs
>
> - shells/newshell/package/contents/ui/mediacenter.qml (ef71938)
>
> View Diff <http://git.reviewboard.kde.org/r/110629/diff/>
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
--
Akshay
[Attachment #5 (text/html)]
Hi Sebastian,<div> </div><div>I know, pretty minor changes are needed \
in this. I was on some other task, but nevertheless, I l do this as soon as possible \
. Thanks for the reminder though :)</div><div><br></div> \
<div>Regards,</div><div>Akshay<br><br><div class="gmail_quote">On Wed, Jun 12, 2013 \
at 1:50 PM, Sebastian Kügler <span dir="ltr"><<a href="mailto:sebas@kde.org" \
target="_blank">sebas@kde.org</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 \
solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110629/" \
target="_blank">http://git.reviewboard.kde.org/r/110629/</a> </td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
has been lingering for two weeks, yet the changes needed are pretty simple: Akshay, \
is this still on your radar?</pre>
<br>
<p>- Sebastian</p><div class="im">
<br>
<p>On May 24th, 2013, 7:46 a.m. UTC, Akshay Ratan wrote:</p>
</div><table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url('');background-repeat:repeat-x;border:1px black \
solid"> <tbody><tr>
<td><div class="im">
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>
</div><p style="color:grey"><i>Updated May 24, 2013, 7:46 a.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div \
class="im"> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Dimming \
the image when it is not viewed directly or more simply when it shows up in \
background while navigating in the Plasma Media Center.
The existing minor problem was that when user views a picture in a slideshow and then \
navigate to the main screen or one level up, the image is shown in the same opacity \
as the original in the background which causes a little discomfort in seeing the \
gallery and other written texts on screen.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Works \
as intended.</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>shells/newshell/package/contents/ui/mediacenter.qml <span \
style="color:grey">(ef71938)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110629/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
Plasma-devel mailing list<br>
<a href="mailto:Plasma-devel@kde.org">Plasma-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/plasma-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/plasma-devel</a><br> \
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Akshay </div>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic