'Re: Review Request 110967: Icontasks: add an option to disable mouse wheel for task switching'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110967: Icontasks: add an option to disable mouse wheel for task switching
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2013-06-12 8:49:58
Message-ID: 20130612084958.18110.57278 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110967/#review34208
-----------------------------------------------------------

hm, this should be a global thing rather a config of a particular applet

- Marco Martin

On June 12, 2013, 8:44 a.m., Luca Manganelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110967/
> -----------------------------------------------------------
> 
> (Updated June 12, 2013, 8:44 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds a checkbox "Disable task switching with scroll wheel" in the \
> configuration dialog box (tab "Behaviour"). 
> Since it adds a new string, I think that this diff will not pushed before KDE 4.11, \
> right? 
> 
> This addresses bug 320523.
> http://bugs.kde.org/show_bug.cgi?id=320523
> 
> 
> Diffs
> -----
> 
> applets/icontasks/behaviourconfig.ui ec0a9ba 
> applets/icontasks/taskgroupitem.h a249391 
> applets/icontasks/taskgroupitem.cpp cdc411f 
> applets/icontasks/tasks.cpp a293564 
> 
> Diff: http://git.reviewboard.kde.org/r/110967/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luca Manganelli
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110967/">http://git.reviewboard.kde.org/r/110967/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hm, this should be a \
global thing rather a config of a particular applet</pre>  <br />

<p>- Marco</p>

<br />
<p>On June 12th, 2013, 8:44 a.m. UTC, Luca Manganelli wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Luca Manganelli.</div>

<p style="color: grey;"><i>Updated June 12, 2013, 8:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a checkbox &quot;Disable task switching with scroll \
wheel&quot; in the configuration dialog box (tab &quot;Behaviour&quot;).

Since it adds a new string, I think that this diff will not pushed before KDE 4.11, \
right?</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=320523">320523</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icontasks/behaviourconfig.ui <span style="color: \
grey">(ec0a9ba)</span></li>

 <li>applets/icontasks/taskgroupitem.h <span style="color: \
grey">(a249391)</span></li>

 <li>applets/icontasks/taskgroupitem.cpp <span style="color: \
grey">(cdc411f)</span></li>

 <li>applets/icontasks/tasks.cpp <span style="color: grey">(a293564)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110967/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 