'Re: Review Request 110783: Fix non-Air icontasks tooltips'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110783: Fix non-Air icontasks tooltips
From:       "Commit Hook" <null () kde ! org>
Date:       2013-06-10 19:57:11
Message-ID: 20130610195711.24436.10397 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110783/
-----------------------------------------------------------

(Updated June 10, 2013, 7:57 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Aaron J. Seigo.

Description
-------

Basically a sync of 9c2df6a32d3904856fffe7bdcfca5836883efc30 from kdelibs, and revert \
of d0237179c5fc321cfb4a78514855bd6c0960ee0f from kdeplasma-addons (icontasks where \
already ported to Plasma::Dialog before the commit)

This addresses bug 320265.
    http://bugs.kde.org/show_bug.cgi?id=320265

Diffs
-----

  applets/icontasks/tooltips/tooltip.cpp b1bb8d3 

Diff: http://git.reviewboard.kde.org/r/110783/diff/

Testing
-------

Tested Air, oxygen, slim-glow, fake air for which i used widget/background for \
tooltip (-> no "shadow" prefix -> tooltip != dialog background). The last three are \
currently broken, and the patch resolves the problem. Now Air uses shadow as it was \
before, and other themes are also rendered properly.

Thanks,

Hrvoje Senjan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110783/">http://git.reviewboard.kde.org/r/110783/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Hrvoje Senjan.</div>

<p style="color: grey;"><i>Updated June 10, 2013, 7:57 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Basically a sync of 9c2df6a32d3904856fffe7bdcfca5836883efc30 from \
kdelibs, and revert of d0237179c5fc321cfb4a78514855bd6c0960ee0f from kdeplasma-addons \
(icontasks where already ported to Plasma::Dialog before the commit)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested Air, oxygen, slim-glow, fake air for which i used \
widget/background for tooltip (-&gt; no &quot;shadow&quot; prefix -&gt; tooltip != \
dialog background). The last three are currently broken, and the patch resolves the \
problem. Now Air uses shadow as it was before, and other themes are also rendered \
properly.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=320265">320265</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/icontasks/tooltips/tooltip.cpp <span style="color: \
grey">(b1bb8d3)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110783/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 