'Re: Review Request 110941: Fix battery status in battery monitor plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110941: Fix battery status in battery monitor plasmoid
From:       "Alberto Villa" <avilla () freebsd ! org>
Date:       2013-06-10 19:05:55
Message-ID: 20130610190555.4678.3484 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110941/
-----------------------------------------------------------

(Updated June 10, 2013, 7:05 p.m.)

Status
------

This change has been discarded.

Review request for Plasma.

Description
-------

Battery monitor sets "batteries.cumulativePluggedin" true when "batteries.count" is \
greater than 0, but it's not a solid way to determine it. At least on FreeBSD, there \
is the possibility that a battery is always listed, even when not plugged in; this \
keeps the plasmoid from reacting on battery removal. The solution is to check that at \
least one battery is plugged in prior to enabling that property.

This is probably due to the way Solid creates the batteries in the dataengine, still \
the patch is an improvement over the current behaviour, in my opinion.

Diffs
-----

  plasma/generic/applets/batterymonitor/contents/code/logic.js 974694a 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml a5e1c13 

Diff: http://git.reviewboard.kde.org/r/110941/diff/

Testing
-------

Tested on FreeBSD 10, confirming the behaviour using some console.log().

Thanks,

Alberto Villa

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110941/">http://git.reviewboard.kde.org/r/110941/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Alberto Villa.</div>

<p style="color: grey;"><i>Updated June 10, 2013, 7:05 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Battery monitor sets &quot;batteries.cumulativePluggedin&quot; true when \
&quot;batteries.count&quot; is greater than 0, but it&#39;s not a solid way to \
determine it. At least on FreeBSD, there is the possibility that a battery is always \
listed, even when not plugged in; this keeps the plasmoid from reacting on battery \
removal. The solution is to check that at least one battery is plugged in prior to \
enabling that property.

This is probably due to the way Solid creates the batteries in the dataengine, still \
the patch is an improvement over the current behaviour, in my opinion.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on FreeBSD 10, confirming the behaviour using some \
console.log().</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/batterymonitor/contents/code/logic.js <span style="color: \
grey">(974694a)</span></li>

 <li>plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml <span \
style="color: grey">(a5e1c13)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110941/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 