From kde-panel-devel Wed May 29 18:57:41 2013 From: "Anne-Marie Mahfouf" Date: Wed, 29 May 2013 18:57:41 +0000 To: kde-panel-devel Subject: Review Request 110716: Get the Plasma Theme Text Color for the Notes applet Message-Id: <20130529185741.9835.43443 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136985389511797 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1555177174388389302==" --===============1555177174388389302== Content-Type: multipart/alternative; boundary="===============1601091897899021730==" --===============1601091897899021730== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110716/ ----------------------------------------------------------- Review request for Plasma, Aaron J. Seigo, Davide Bettio, and Sebastian Kügler. Description ------- For theme text color, the code was Plasma::Theme::ButtonTextColor instead of Plasma::Theme::TextColor in 2 places. When the theme changes, make the text change color. This addresses bug 320342. http://bugs.kde.org/show_bug.cgi?id=320342 Diffs ----- applets/notes/notes.cpp 5c2ed70 Diff: http://git.reviewboard.kde.org/r/110716/diff/ Testing ------- Tested with several themes, Air, ThinAir2 and Oxygen. Thanks, Anne-Marie Mahfouf --===============1601091897899021730== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110716/

Review request for Plasma, Aaron J. Seigo, Davide Bettio, and Sebastian Kügler.
By Anne-Marie Mahfouf.

Description

For theme text color, the code was Plasma::Theme::ButtonTextColor instead of Plasma::Theme::TextColor in 2 places. When the theme changes, make the text change color.

Testing

Tested with several themes, Air, ThinAir2 and Oxygen. 
Bugs: 320342

Diffs

  • applets/notes/notes.cpp (5c2ed70)

View Diff

--===============1601091897899021730==-- --===============1555177174388389302== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1555177174388389302==--