[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110684: Do not show the "File to activity linking plugin" in context menus by def
From: Ivan Čukić <ivan.cukic () kde ! org>
Date: 2013-05-28 8:30:31
Message-ID: 20130528083031.10597.34604 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110684/#review33267
-----------------------------------------------------------
Ship it!
Ship It!
- Ivan Čukić
On May 28, 2013, 3:51 a.m., Frank Reininghaus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110684/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 3:51 a.m.)
>
>
> Review request for Plasma and Ivan Čukić.
>
>
> Description
> -------
>
> The "File to activity linking plugin" performs some operations on startup that are \
> not guaranteed to succeed fast. Therefore, it can freeze the host application if \
> the user tries to open the context menu. IMHO, this is not acceptable for a plugin \
> that is enabled for every KDE user by default, even those who do not use the \
> plugin, or even do not use Activities at all. Well, I think it is questionable if \
> potentially blocking operations should be done in a context menu plugin at all, but \
> I see that there might be no other way to do it which would be equally \
> user-friendly way for people who do use the plugin to link files to activities. \
> Therefore, I propose this compromise which makes sure that only users who \
> consciously enable the plugin are exposed to its potential drawbacks.
> Depends on my earlier kdelibs request https://git.reviewboard.kde.org/r/110625/ , \
> which did not get any objections so far.
> From my point of view, the only alternative is a Dolphin-internal solution that \
> either disables the plugin unless it has been enabled explicitly or just bans it \
> from the context menu. This would be easier for me and require less code changes, \
> but I believe that the solution that I'm proposing here is preferable because it is \
> more transparent and gives both users and plugin developers a choice.
>
> This addresses bug 314575.
> http://bugs.kde.org/show_bug.cgi?id=314575
>
>
> Diffs
> -----
>
> src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp 82cb8db
>
> Diff: http://git.reviewboard.kde.org/r/110684/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Frank Reininghaus
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110684/">http://git.reviewboard.kde.org/r/110684/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Ivan</p>
<br />
<p>On May 28th, 2013, 3:51 a.m. UTC, Frank Reininghaus wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Frank Reininghaus.</div>
<p style="color: grey;"><i>Updated May 28, 2013, 3:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The "File to activity linking plugin" performs some operations \
on startup that are not guaranteed to succeed fast. Therefore, it can freeze the host \
application if the user tries to open the context menu. IMHO, this is not acceptable \
for a plugin that is enabled for every KDE user by default, even those who do not use \
the plugin, or even do not use Activities at all. Well, I think it is questionable if \
potentially blocking operations should be done in a context menu plugin at all, but I \
see that there might be no other way to do it which would be equally user-friendly \
way for people who do use the plugin to link files to activities. Therefore, I \
propose this compromise which makes sure that only users who consciously enable the \
plugin are exposed to its potential drawbacks.
Depends on my earlier kdelibs request https://git.reviewboard.kde.org/r/110625/ , \
which did not get any objections so far.
From my point of view, the only alternative is a Dolphin-internal solution that \
either disables the plugin unless it has been enabled explicitly or just bans it from \
the context menu. This would be easier for me and require less code changes, but I \
believe that the solution that I'm proposing here is preferable because it is \
more transparent and gives both users and plugin developers a choice.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=314575">314575</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/workspace/fileitemplugin/FileItemLinkingPlugin.cpp <span style="color: \
grey">(82cb8db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110684/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic