[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110504: Group tasks by activity
From: José Millán Soto <fid () gpul ! org>
Date: 2013-05-26 14:05:51
Message-ID: 20130526140551.30360.32863 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 26, 2013, 9:42 a.m., Marco Martin wrote:
> > The libtaskmanager part is nice.
> >
> > However the applet is about t be replaced, so the display part would \
> > have to be redone
I am aware that the tasks applet is going to be replaced soon, but most \
changes of this patch are in the library and not in the applet. I don't \
mind creating a patch for the new version of the applet to handle this \
grouping once the new version of the applet is available.
- José
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110504/#review33145
-----------------------------------------------------------
On May 18, 2013, 2:13 p.m., José Millán Soto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110504/
> -----------------------------------------------------------
>
> (Updated May 18, 2013, 2:13 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> New grouping strategy was created to allow tasks to be grouped by \
> activity. If an item is available in multiple activities, it will only \
> appear in one of the activities the task is available on (except if it's \
> available on all activities). GroupManager was modified so that whether \
> items should be grouped just when the task bar is full or not is not only \
> taken into account when grouping by program but also when grouping by \
> activity. Activity icons are not handled yet, so an icon from the first \
> task which was on the group is used as the icon of the task group.
>
> Diffs
> -----
>
> plasma/desktop/applets/tasks/tasks.cpp dbbb0cb
> libs/taskmanager/strategies/activitygroupingstrategy.cpp PRE-CREATION
> libs/taskmanager/groupmanager.cpp 9ac15e7
> libs/taskmanager/strategies/activitygroupingstrategy.h PRE-CREATION
> libs/taskmanager/CMakeLists.txt 70fa791
> libs/taskmanager/groupmanager.h ad4167a
>
> Diff: http://git.reviewboard.kde.org/r/110504/diff/
>
>
> Testing
> -------
>
> Three activities were created (named "Activity 1", "Activity 2" and \
> "Activity 3"). One instance of KDialog was assigned to Activity 1, two \
> instances of KDialog were assigned to Activity 2, three instances of \
> KDialog were assigned to Activity 3 and one instance of KDialog was \
> assigned both to Activities 2 & 3. The tasks applet was executed in \
> plasma-windowed in all activities. Screenshot 1 & 2 show the task manager \
> in the situation described above. Screenshot 3 shows the same task \
> manager after leaving only one instance of KDialog in each activity \
> ("Only group when taskbar is full" enabled), and screenshot 4 shows the \
> task manager when the tasks are the same that in screenshot 3 but "Only \
> group when taskbar is full" is disabled.
>
> File Attachments
> ----------------
>
> Screenshot 1
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png
> Screenshot 2
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png
> Screenshot 3
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png
> Screenshot 4
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png
>
>
> Thanks,
>
> José Millán Soto
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110504/">http://git.reviewboard.kde.org/r/110504/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On May 26th, 2013, 9:42 \
a.m. UTC, <b>Marco Martin</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The \
libtaskmanager part is nice.
However the applet is about t be replaced, so the display part would have \
to be redone</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am aware \
that the tasks applet is going to be replaced soon, but most changes of \
this patch are in the library and not in the applet. I don't mind \
creating a patch for the new version of the applet to handle this grouping \
once the new version of the applet is available.</pre> <br />
<p>- José</p>
<br />
<p>On May 18th, 2013, 2:13 p.m. UTC, José Millán Soto wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated May 18, 2013, 2:13 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New grouping strategy was created to allow tasks to be grouped \
by activity. If an item is available in multiple activities, it will only \
appear in one of the activities the task is available on (except if \
it's available on all activities). GroupManager was modified so that \
whether items should be grouped just when the task bar is full or not is \
not only taken into account when grouping by program but also when grouping \
by activity. Activity icons are not handled yet, so an icon from the first \
task which was on the group is used as the icon of the task group.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Three activities were created (named "Activity 1", \
"Activity 2" and "Activity 3"). One instance of KDialog \
was assigned to Activity 1, two instances of KDialog were assigned to \
Activity 2, three instances of KDialog were assigned to Activity 3 and one \
instance of KDialog was assigned both to Activities 2 & 3. The tasks \
applet was executed in plasma-windowed in all activities. Screenshot 1 \
& 2 show the task manager in the situation described above. Screenshot \
3 shows the same task manager after leaving only one instance of KDialog in \
each activity ("Only group when taskbar is full" enabled), and \
screenshot 4 shows the task manager when the tasks are the same that in \
screenshot 3 but "Only group when taskbar is full" is \
disabled.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/tasks/tasks.cpp <span style="color: \
grey">(dbbb0cb)</span></li>
<li>libs/taskmanager/strategies/activitygroupingstrategy.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/groupmanager.cpp <span style="color: \
grey">(9ac15e7)</span></li>
<li>libs/taskmanager/strategies/activitygroupingstrategy.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>libs/taskmanager/CMakeLists.txt <span style="color: \
grey">(70fa791)</span></li>
<li>libs/taskmanager/groupmanager.h <span style="color: \
grey">(ad4167a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110504/diff/" \
style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File \
Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img1.png">Screenshot \
1</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img2.png">Screenshot \
2</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img3.png">Screenshot \
3</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/18/img4.png">Screenshot \
4</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic