'Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataen'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110608: Add support for keyboard backlight handling to the powermanagement dataen
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2013-05-26 9:40:39
Message-ID: 20130526094039.28437.84188 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On May 26, 2013, 9:39 a.m., Marco Martin wrote:
> > Ship It!

At least for the plasma part, some feedback by solid people would be appreciated as \
well ;)

- Marco

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110608/#review33143
-----------------------------------------------------------

On May 23, 2013, 9:13 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110608/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:13 a.m.)
> 
> 
> Review request for Plasma and Solid.
> 
> 
> Description
> -------
> 
> This patch adds support for keyboard backlight handling to the powermanagement \
> dataengine. 
> It is similar to the backlight handling. Allows setting and getting they keyboard \
> brightness and checking whether it is supported at all. 
> 
> Diffs
> -----
> 
> plasma/generic/dataengines/powermanagement/powermanagementengine.h 319a17c 
> plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 4b184fa 
> plasma/generic/dataengines/powermanagement/powermanagementjob.h 3b974ab 
> plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006 
> plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
> 533c00a  
> Diff: http://git.reviewboard.kde.org/r/110608/diff/
> 
> 
> Testing
> -------
> 
> Adjusting keyboard brightness from the battery monitor so coooool.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110608/">http://git.reviewboard.kde.org/r/110608/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On May 26th, 2013, 9:39 a.m. UTC, <b>Marco \
Martin</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At least for the plasma \
part, some feedback by solid people would be appreciated as well ;)</pre> <br />

<p>- Marco</p>

<br />
<p>On May 23rd, 2013, 9:13 a.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Solid.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated May 23, 2013, 9:13 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for keyboard backlight handling to the \
powermanagement dataengine.

It is similar to the backlight handling. Allows setting and getting they keyboard \
brightness and checking whether it is supported at all.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adjusting keyboard brightness from the battery monitor so coooool.</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span \
style="color: grey">(319a17c)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span \
style="color: grey">(4b184fa)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span \
style="color: grey">(3b974ab)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span \
style="color: grey">(6f90006)</span></li>

 <li>plasma/generic/dataengines/powermanagement/powermanagementservice.operations \
<span style="color: grey">(533c00a)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110608/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 