[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-05-25 6:15:00
Message-ID: 20130525061500.3565.6827 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 24, 2013, 11:44 p.m., Jekyll Wu wrote:
> > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled \
> > versions. So even without this patch, DrKonqi users won't be able to create crash \
> > report against disabled versions in the end. From developers POV, you don't need \
> > to worry about that.
> > The problem is usability for users. I'm not sure this reused error dialog is more \
> > informative than the existing one in \
> > https://bugs.kde.org/attachment.cgi?id=78600&action=edit. So I'm against this \
> > patch in its current simple form.
> > As said in [1][2], I'm working on a patch for the usability improvement and plan \
> > to make it into 4.11. I will create a review request today or tomorrow.
> >
> > [1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
> > [2] https://bugs.kde.org/show_bug.cgi?id=318769#c1
>
> Martin Gräßlin wrote:
> > Bugzilla itself (since 4.2.5) already rejects any attempt against disabled \
> > versions.
> Bugzilla does blcok, but DrKonqi still reports them as "unknown" version. I know it \
> because I see the crash reports coming in
> So I'm against this patch in its current simple form.
Are you also against into backporting it to prevent that we stop getting useless \
crash reports? I worked on this for fixing a real world problem. Just look at: \
https://bugs.kde.org/buglist.cgi?list_id=661927&bug_severity=crash&chfieldto=Now&query \
_format=advanced&chfield=[Bug%20creation]&chfieldfrom=2013-01-01&version=unspecified&longdesc=kwin%20%284.8&product=kwin&longdesc_type=allwordssubstr
All crashes reported this year against KWin 4.8.
Yes the dialog might not be best, but I cannot change it because it's in string \
freeze. I agree that for 4.11 something better should be done, but this is more for \
4.10 and older (especially older).
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110633/#review33110
-----------------------------------------------------------
On May 24, 2013, 4:54 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110633/
> -----------------------------------------------------------
>
> (Updated May 24, 2013, 4:54 p.m.)
>
>
> Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam Schweingruber.
>
>
> Description
> -------
>
> Bugzilla provides a feature to disable versions. This means that the developers do \
> not want to have further reports for this version. Any crash report is by that not \
> helpful any more. So let's just disable reporting crashes for such bugs.
> If this change gets accepted I intend to backport it to 4.10 and to inform \
> kde-packagers about it to ship it as an update to *all* version they support. This \
> would automatically prevent most duplicates report we get e.g. for KWin.
>
> Diffs
> -----
>
> drkonqi/reportinterface.cpp 4190c40
>
> Diff: http://git.reviewboard.kde.org/r/110633/diff/
>
>
> Testing
> -------
>
> See https://bugs.kde.org/show_bug.cgi?id=320217 - the bug was created with version \
> 4.10.60. Afterward the version got disabled and DrKonqi doesn't allow me to report \
> crashes for this version anymore.
>
> File Attachments
> ----------------
>
> With it disabled
> http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png
>
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110633/">http://git.reviewboard.kde.org/r/110633/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 24th, 2013, 11:44 p.m. CEST, <b>Jekyll \
Wu</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bugzilla itself (since 4.2.5) already rejects any attempt against \
disabled versions. So even without this patch, DrKonqi users won't be able to \
create crash report against disabled versions in the end. From developers POV, you \
don't need to worry about that.
The problem is usability for users. I'm not sure this reused error dialog is more \
informative than the existing one in \
https://bugs.kde.org/attachment.cgi?id=78600&action=edit. So I'm against this \
patch in its current simple form.
As said in [1][2], I'm working on a patch for the usability improvement and plan \
to make it into 4.11. I will create a review request today or tomorrow.
[1] https://bugs.kde.org/show_bug.cgi?id=315073#c3
[2] https://bugs.kde.org/show_bug.cgi?id=318769#c1</pre>
</blockquote>
<p>On May 25th, 2013, 8:06 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Bugzilla itself \
(since 4.2.5) already rejects any attempt against disabled versions. Bugzilla does \
blcok, but DrKonqi still reports them as "unknown" version. I know it \
because I see the crash reports coming in</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> So I'm against \
this patch in its current simple form. Are you also against into backporting it to \
prevent that we stop getting useless crash reports? I worked on this for fixing a \
real world problem. Just look at: \
https://bugs.kde.org/buglist.cgi?list_id=661927&bug_severity=crash&chfieldto=N \
ow&query_format=advanced&chfield=[Bug%20creation]&chfieldfrom=2013-01-01&a \
mp;version=unspecified&longdesc=kwin%20%284.8&product=kwin&longdesc_type=allwordssubstr
All crashes reported this year against KWin 4.8.
Yes the dialog might not be best, but I cannot change it because it's in string \
freeze. I agree that for 4.11 something better should be done, but this is more for \
4.10 and older (especially older).</pre> <br />
<p>- Martin</p>
<br />
<p>On May 24th, 2013, 4:54 p.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime, Plasma, Ben Cooksley, and Myriam \
Schweingruber.</div> <div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated May 24, 2013, 4:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Bugzilla provides a feature to disable versions. This means that the \
developers do not want to have further reports for this version. Any crash report is \
by that not helpful any more. So let's just disable reporting crashes for such \
bugs.
If this change gets accepted I intend to backport it to 4.10 and to inform \
kde-packagers about it to ship it as an update to *all* version they support. This \
would automatically prevent most duplicates report we get e.g. for KWin.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">See https://bugs.kde.org/show_bug.cgi?id=320217 - the bug was created \
with version 4.10.60. Afterward the version got disabled and DrKonqi doesn't \
allow me to report crashes for this version anymore.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>drkonqi/reportinterface.cpp <span style="color: grey">(4190c40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110633/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/24/drkonqi-disabled.png">With \
it disabled</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic