[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110621: Drag and Drop feature to swap items in playlist added.
From: "Shantanu Tushar" <shantanu () kde ! org>
Date: 2013-05-24 5:58:17
Message-ID: 20130524055817.12921.22374 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110621/#review33070
-----------------------------------------------------------
Thanks for the patch :)
libs/mediacenter/playlistmodel.h
<http://git.reviewboard.kde.org/r/110621/#comment24453>
better names would be firstIndex and secondIndex
libs/mediacenter/playlistmodel.cpp
<http://git.reviewboard.kde.org/r/110621/#comment24454>
resetting the whole model is an expensive operation. Its better to use \
beginMoveRows for the source index. \
http://qt-project.org/doc/qt-4.8/qabstractitemmodel.html#beginMoveRows
- Shantanu Tushar
On May 23, 2013, 7:36 p.m., saurabh jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110621/
> -----------------------------------------------------------
>
> (Updated May 23, 2013, 7:36 p.m.)
>
>
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
>
>
> Description
> -------
>
> Reordering of the songs in the playlist is now possible using this patch. Just drag \
> and drop the item to the desired place (where you want to replace it with the item \
> at desired location).
>
> Diffs
> -----
>
> libs/mediacenter/playlistmodel.h 2c1dc6b
> libs/mediacenter/playlistmodel.cpp 40b490c
> mediaelements/playlist/PlaylistDelegate.qml b1e6f40
>
> Diff: http://git.reviewboard.kde.org/r/110621/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> saurabh jain
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110621/">http://git.reviewboard.kde.org/r/110621/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the patch \
:)</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110621/diff/2/?file=146070#file146070line53" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/playlistmodel.h</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">53</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">Q_INVOKABLE</span> <span class="kt">void</span> <span \
class="nf">swapItems</span><span class="p">(</span><span class="kt">int</span> <span \
class="n">index1</span><span class="p">,</span><span class="kt">int</span> <span \
class="n">index2</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">better \
names would be firstIndex and secondIndex</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110621/diff/2/?file=146071#file146071line134" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/mediacenter/playlistmodel.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">134</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">beginResetModel</span><span class="p">();</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">135</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">d</span><span class="o">-></span><span class="n">musicList</span><span \
class="p">.</span><span class="n">swap</span><span class="p">(</span><span \
class="n">index1</span><span class="p">,</span><span class="n">index2</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">136</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">endResetModel</span><span class="p">();</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">resetting \
the whole model is an expensive operation. Its better to use beginMoveRows for the \
source index. http://qt-project.org/doc/qt-4.8/qabstractitemmodel.html#beginMoveRows</pre>
</div>
<br />
<p>- Shantanu</p>
<br />
<p>On May 23rd, 2013, 7:36 p.m. UTC, saurabh jain wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By saurabh jain.</div>
<p style="color: grey;"><i>Updated May 23, 2013, 7:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Reordering of the songs in the playlist is now possible using this \
patch. Just drag and drop the item to the desired place (where you want to replace it \
with the item at desired location). </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/mediacenter/playlistmodel.h <span style="color: grey">(2c1dc6b)</span></li>
<li>libs/mediacenter/playlistmodel.cpp <span style="color: \
grey">(40b490c)</span></li>
<li>mediaelements/playlist/PlaylistDelegate.qml <span style="color: \
grey">(b1e6f40)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110621/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic