'Re: Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110467: Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-19 20:02:17
Message-ID: 20130519200217.25161.86952 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110467/#review32787
-----------------------------------------------------------

This review has been submitted with commit 00216d9b7ab47440ddef2a0e10250955cbf46392 \
by Luca Beltrame on behalf of Vishesh Handa to branch master.

- Commit Hook

On May 17, 2013, 6:02 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110467/
> -----------------------------------------------------------
> 
> (Updated May 17, 2013, 6:02 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo
> 
> 1. The Xesam width and height properties are never returned by strigi
> and haven't been returned for a very very long time. It currently
> returns the nfo:width and nfo:height property instead.
> 
> 2. KFileMetadataWidget is blocking and blocks while it is calculating
> the height and width. It is better to open the file and calculate it in
> another thread as done by the ImageSizeFinder
> 
> 3. QImage in more reliable and actively maintained in contrast to
> strigi.
> 
> 
> Diffs
> -----
> 
> plasma/generic/wallpapers/image/backgroundlistmodel.cpp c4093a7 
> 
> Diff: http://git.reviewboard.kde.org/r/110467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110467/">http://git.reviewboard.kde.org/r/110467/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 00216d9b7ab47440ddef2a0e10250955cbf46392 by Luca Beltrame on \
behalf of Vishesh Handa to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 17th, 2013, 6:02 p.m. UTC, Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated May 17, 2013, 6:02 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">    Plasma Wallpaper BackgroundListModel: Avoid using KFileMetaInfo  
    1. The Xesam width and height properties are never returned by strigi
    and haven&#39;t been returned for a very very long time. It currently
    returns the nfo:width and nfo:height property instead.

    2. KFileMetadataWidget is blocking and blocks while it is calculating
    the height and width. It is better to open the file and calculate it in
    another thread as done by the ImageSizeFinder

    3. QImage in more reliable and actively maintained in contrast to
    strigi.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/wallpapers/image/backgroundlistmodel.cpp <span style="color: \
grey">(c4093a7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110467/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 