'Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alp'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alp
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-16 15:09:30
Message-ID: 20130516150930.1961.65579 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110427/
-----------------------------------------------------------

(Updated May 16, 2013, 3:09 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma, Aaron J. Seigo and Marco Martin.

Description
-------

This patch aims to allow Plasma::ConfigLoader to properly load default values of \
QColor that contains alpha channel (bug #318504). Apparently constructor of QColor \
which takes QString as value fails to detect and properly (QColor with alpha channel \
is handled properly by KConfigGroup).

This addresses bug 318504.
    http://bugs.kde.org/show_bug.cgi?id=318504

Diffs
-----

  plasma/configloader.cpp 5c67474 
  plasma/tests/configloadertest.h ed5a32c 
  plasma/tests/configloadertest.cpp 6737cae 
  plasma/tests/configloadertest.xml 13ccd32 

Diff: http://git.reviewboard.kde.org/r/110427/diff/

Testing
-------

Compiles, unit test passes (assuming that it was done correctly ;-)).

Thanks,

Michał Dutkiewicz

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110427/">http://git.reviewboard.kde.org/r/110427/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Michał Dutkiewicz.</div>

<p style="color: grey;"><i>Updated May 16, 2013, 3:09 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch aims to allow Plasma::ConfigLoader to properly load default \
values of QColor that contains alpha channel (bug #318504). Apparently constructor of \
QColor which takes QString as value fails to detect and properly (QColor with alpha \
channel is handled properly by KConfigGroup).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles, unit test passes (assuming that it was done correctly \
;-)).</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318504">318504</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/configloader.cpp <span style="color: grey">(5c67474)</span></li>

 <li>plasma/tests/configloadertest.h <span style="color: grey">(ed5a32c)</span></li>

 <li>plasma/tests/configloadertest.cpp <span style="color: \
grey">(6737cae)</span></li>

 <li>plasma/tests/configloadertest.xml <span style="color: \
grey">(13ccd32)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110427/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 