[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110413: Show in the tasks applet the activities a task is available on
From: José Millán Soto <fid () gpul ! org>
Date: 2013-05-15 16:04:55
Message-ID: 20130515160455.8692.75430 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110413/
-----------------------------------------------------------
(Updated May 15, 2013, 4:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Description
-------
This patch adds information about the activities on which a task is available to the \
tooltip. Two methods to obtain information about the activities a task is available, \
activities and activityNames, where added to TaskManager::TaskItem. Depending whether \
the applet is configured to show tasks which are not available in the current \
activity or not, the information displayed will be different. If the applet is \
configured to show only tasks in current activity, only the tasks which are also \
available in other activities will have this information in the tooltip.
This addresses bug 307163.
http://bugs.kde.org/show_bug.cgi?id=307163
Diffs
-----
libs/taskmanager/taskitem.h 35606e2
libs/taskmanager/taskitem.cpp c9613c9
plasma/desktop/applets/tasks/windowtaskitem.cpp f840076
Diff: http://git.reviewboard.kde.org/r/110413/diff/
Testing
-------
In order to test this patch, three activities (called "Activity 1", "Activity 2" and \
"Activity 3") were created. Various instances of KDialog were created, all of them in \
desktop 1, and they were assigned to various activities (The title of the dialog was \
set to AxDi, where x are the activities on which the dialog will be available). All \
screenshots were taken on activity 1. Screenshots 1 to 3 were taken with the taskbar \
configured to display tasks in all activities but only in desktop 1. Screenshots 4 to \
6 were taken with the configuration to show tasks only in current activity. \
Screenshot 7 was taken with the taskbar displaying all tasks from all desktops. \
Screenshot 8 was created with the taskbar configured to group elements by program \
(activity information is not yet available).
File Attachments
----------------
Screenshot 1
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png
Screenshot 2
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png
Screenshot 3
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png
Screenshot 4
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png
Screenshot 5
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png
Screenshot 6
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png
Screenshot 7
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png
Screenshot 8
http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png
Thanks,
José Millán Soto
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110413/">http://git.reviewboard.kde.org/r/110413/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By José Millán Soto.</div>
<p style="color: grey;"><i>Updated May 15, 2013, 4:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds information about the activities on which a task is \
available to the tooltip. Two methods to obtain information about the activities a \
task is available, activities and activityNames, where added to \
TaskManager::TaskItem. Depending whether the applet is configured to show tasks which \
are not available in the current activity or not, the information displayed will be \
different. If the applet is configured to show only tasks in current activity, only \
the tasks which are also available in other activities will have this information in \
the tooltip.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In order to test this patch, three activities (called "Activity \
1", "Activity 2" and "Activity 3") were created. Various \
instances of KDialog were created, all of them in desktop 1, and they were assigned \
to various activities (The title of the dialog was set to AxDi, where x are the \
activities on which the dialog will be available). All screenshots were taken on \
activity 1. Screenshots 1 to 3 were taken with the taskbar configured to display \
tasks in all activities but only in desktop 1. Screenshots 4 to 6 were taken with the \
configuration to show tasks only in current activity. Screenshot 7 was taken with the \
taskbar displaying all tasks from all desktops. Screenshot 8 was created with the \
taskbar configured to group elements by program (activity information is not yet \
available).</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307163">307163</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/taskmanager/taskitem.h <span style="color: grey">(35606e2)</span></li>
<li>libs/taskmanager/taskitem.cpp <span style="color: grey">(c9613c9)</span></li>
<li>plasma/desktop/applets/tasks/windowtaskitem.cpp <span style="color: \
grey">(f840076)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110413/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot1.png">Screenshot \
1</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot2.png">Screenshot \
2</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot3.png">Screenshot \
3</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot4.png">Screenshot \
4</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot5.png">Screenshot \
5</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot6.png">Screenshot \
6</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot7.png">Screenshot \
7</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/05/13/snapshot8.png">Screenshot \
8</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic