[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110406: Expose more battery properties to the Power Management dataengine
From: "Commit Hook" <null () kde ! org>
Date: 2013-05-14 21:29:15
Message-ID: 20130514212915.32239.70548 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110406/
-----------------------------------------------------------
(Updated May 14, 2013, 9:29 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Description
-------
Depends on Review 110384
This patch makes exposes more battery properties to the Power Management dataengine, \
namely:
- Name: This is the device name of the battery. It will usually be "Unknown Battery" \
but if you eg. attach a mouse (tested with Apple Magic Mouse) or another battery \
device with a name, it will show this. This will eventually allow the battery monitor \
to not just show Battery 1, Battery 2, but actually the device name.
- Type: The type of battery, such as Primary (for internal notebook batteries) or \
Mouse. This could also be useful to show eg. a device icon in the battery monitor.
- Power Supply: If the battery is actually powering the machine (ie. notebook \
battery) or coming from one of the peripherals (Mouse, Keyboard, ..). This will \
eventually allow the battery monitor to disregard those devices when calculating \
overall battery percentage, or group peripheral devices visually separated, or so.
Diffs
-----
plasma/generic/dataengines/powermanagement/powermanagementengine.cpp d1b9519
plasma/generic/dataengines/powermanagement/powermanagementengine.h 35e9ecf
Diff: http://git.reviewboard.kde.org/r/110406/diff/
Testing
-------
Tested with Apple Magic Mouse and it properly reported its name and power supply \
state. The Type property is somewhat unreliable as UPower also considered the mouse \
as Primary battery. But the Is Power Supply property was correct and that's the \
prevailing one.
Thanks,
Kai Uwe Broulik
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110406/">http://git.reviewboard.kde.org/r/110406/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 14, 2013, 9:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Depends on Review 110384
This patch makes exposes more battery properties to the Power Management dataengine, \
namely:
- Name: This is the device name of the battery. It will usually be "Unknown \
Battery" but if you eg. attach a mouse (tested with Apple Magic Mouse) or \
another battery device with a name, it will show this. This will eventually allow the \
battery monitor to not just show Battery 1, Battery 2, but actually the device name.
- Type: The type of battery, such as Primary (for internal notebook batteries) or \
Mouse. This could also be useful to show eg. a device icon in the battery monitor.
- Power Supply: If the battery is actually powering the machine (ie. notebook \
battery) or coming from one of the peripherals (Mouse, Keyboard, ..). This will \
eventually allow the battery monitor to disregard those devices when calculating \
overall battery percentage, or group peripheral devices visually separated, or so. \
</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with Apple Magic Mouse and it properly reported its name and \
power supply state. The Type property is somewhat unreliable as UPower also \
considered the mouse as Primary battery. But the Is Power Supply property was correct \
and that's the prevailing one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span \
style="color: grey">(d1b9519)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span \
style="color: grey">(35e9ecf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110406/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic