[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110290: Share data engine - add im9.eu images upload service
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-05-04 0:00:51
Message-ID: 20130504000051.32242.16752 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110290/#review31983
-----------------------------------------------------------
Ship it!
Some small niggles, looks pretty good already. Please change those, then it's good to \
go into master.
plasma/generic/dataengines/share/backends/im9/CMakeLists.txt
<http://git.reviewboard.kde.org/r/110290/#comment23825>
install the directory, not the individual files. That way, when someone adds a \
file (for example by splitting out something from main.js), the CMakeLists.txt files \
doesn't need adjustment. It's also more in line with how we do it in the rest of \
Plasma.
plasma/generic/dataengines/share/backends/im9/contents/code/main.js
<http://git.reviewboard.kde.org/r/110290/#comment23826>
stray whitespace - remove it
- Sebastian Kügler
On May 3, 2013, 8:48 p.m., Michał Dutkiewicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110290/
> -----------------------------------------------------------
>
> (Updated May 3, 2013, 8:48 p.m.)
>
>
> Review request for Plasma, Aaron J. Seigo, Artur Duque de Souza, and Marco Martin.
>
>
> Description
> -------
>
> This patch adds support for im9.eu images upload service to share data engine.
>
>
> Diffs
> -----
>
> plasma/generic/dataengines/share/backends/CMakeLists.txt 30695d3
> plasma/generic/dataengines/share/backends/im9/CMakeLists.txt PRE-CREATION
> plasma/generic/dataengines/share/backends/im9/contents/code/main.js PRE-CREATION
> plasma/generic/dataengines/share/backends/im9/metadata.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/110290/diff/
>
>
> Testing
> -------
>
> Tested with KDE 4.10, works fine.
>
>
> Thanks,
>
> Michał Dutkiewicz
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110290/">http://git.reviewboard.kde.org/r/110290/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some small niggles, \
looks pretty good already. Please change those, then it's good to go into \
master.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110290/diff/1/?file=141951#file141951line7" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/dataengines/share/backends/im9/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">7</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">DESTINATION</span> <span class="o">${</span><span \
class="nv">DATA_INSTALL_DIR</span><span class="o">}</span><span \
class="s">/plasma/shareprovider/im9/contents/code/</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">install the \
directory, not the individual files. That way, when someone adds a file (for example \
by splitting out something from main.js), the CMakeLists.txt files doesn't need \
adjustment. It's also more in line with how we do it in the rest of Plasma.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110290/diff/1/?file=141952#file141952line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/dataengines/share/backends/im9/contents/code/main.js</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"><span class="tb"> </span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">stray \
whitespace - remove it</pre> </div>
<br />
<p>- Sebastian</p>
<br />
<p>On May 3rd, 2013, 8:48 p.m. UTC, Michał Dutkiewicz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo, Artur Duque de Souza, and Marco \
Martin.</div> <div>By Michał Dutkiewicz.</div>
<p style="color: grey;"><i>Updated May 3, 2013, 8:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for im9.eu images upload service to share data \
engine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with KDE 4.10, works fine.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/share/backends/CMakeLists.txt <span style="color: \
grey">(30695d3)</span></li>
<li>plasma/generic/dataengines/share/backends/im9/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/generic/dataengines/share/backends/im9/contents/code/main.js <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/generic/dataengines/share/backends/im9/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110290/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic