--===============9181156978506477995== Content-Type: multipart/alternative; boundary="===============4106221337554834945==" --===============4106221337554834945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/#review31812 ----------------------------------------------------------- Ship it! elevating the dragged window makes it acceptable even with opaque themes and a clear improvement over the status quo in about all cases. - Thomas Lübking On April 26, 2013, 6 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110176/ > ----------------------------------------------------------- > > (Updated April 26, 2013, 6 a.m.) > > > Review request for kwin and Plasma. > > > Description > ------- > > Change the visual appearance of the composited outline > > Uses widgets/translucentbackground as FrameSvg item to ensure that we > don't get a huge black square on the screen. > > When bordering a screen edge we disable the border except if all edges > are bordered. This makes a little bit more clear in the quick tiling case > what will be the geometry. > > Blur behind the outline does not work as: > * moving the window generates artefacts > * moved window needs to be above the outline, but outline needs to be on > top of everything. Elevating the moved window results in strange > side effects when moving the window "below" a keep above, etc. > > > Diffs > ----- > > kwin/geometry.cpp 5a6786d > kwin/outline.cpp ad3cfc0 > > Diff: http://git.reviewboard.kde.org/r/110176/diff/ > > > Testing > ------- > > I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes. > > > Thanks, > > Martin Gräßlin > > --===============4106221337554834945== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110176/

Ship it!

elevating the dragged window makes it acceptable even with opaque themes and a clear improvement over the status quo in about all cases.

- Thomas

On April 26th, 2013, 6 a.m. UTC, Martin Gräßlin wrote:

Review request for kwin and Plasma.

By Martin Gräßlin.

Updated April 26, 2013, 6 a.m.

Description

Change the visual appearance of the composited outline

Uses widgets/translucentbackground as FrameSvg item to ensure that we
don't get a huge black square on the screen.

When bordering a screen edge we disable the border except if all edges
are bordered. This makes a little bit more clear in the quick tiling case
what will be the geometry.

Blur behind the outline does not work as:
* moving the window generates artefacts
* moved window needs to be above the outline, but outline needs to be on
  top of everything. Elevating the moved window results in strange
  side effects when moving the window "below" a keep above, etc.

Testing

I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes.

Diffs

kwin/geometry.cpp (5a6786d)
kwin/outline.cpp (ad3cfc0)

--===============4106221337554834945==-- --===============9181156978506477995== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9181156978506477995==--