--===============6813214411974041126== Content-Type: multipart/alternative; boundary="===============8417287033184897100==" --===============8417287033184897100== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110208/ ----------------------------------------------------------- (Updated April 29, 2013, 1:49 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma and Martin Gräßlin. Description ------- Fix memleak: make ~DialogShadows delete DialogShadows::Private Diffs ----- plasma/private/dialogshadows.cpp e787fd4ec4e39cab275328b5c69aad716c826788 plasma/private/dialogshadows_p.h a2d62ccbe6be7908e076409fd418f48027e5f5da Diff: http://git.reviewboard.kde.org/r/110208/diff/ Testing ------- Ran Plasma, without crash, tooltips still work. Ran upcoming, Plasma::Dialog-based, Colibri: the change makes Valgrind a bit happier. Thanks, Aurélien Gâteau --===============8417287033184897100== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110208/

This change has been marked as submitted.


Review request for Plasma and Martin Gräßlin.
By Aurélien Gâteau.

Updated April 29, 2013, 1:49 p.m.

Description

Fix memleak: make ~DialogShadows delete DialogShadows::Private

Testing

Ran Plasma, without crash, tooltips still work.
Ran upcoming, Plasma::Dialog-based, Colibri: the change makes Valgrind a bit happier.

Diffs

  • plasma/private/dialogshadows.cpp (e787fd4ec4e39cab275328b5c69aad716c826788)
  • plasma/private/dialogshadows_p.h (a2d62ccbe6be7908e076409fd418f48027e5f5da)

View Diff

--===============8417287033184897100==-- --===============6813214411974041126== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6813214411974041126==--