[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110176: Change the visual appearance of the composited outline
From: Martin_Gräßlin <mgraesslin () kde ! org>
Date: 2013-04-26 6:01:02
Message-ID: 20130426060102.11895.90773 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 25, 2013, 11:10 a.m., Marco Martin wrote:
> > seems a nice idea.
> > since the shadow for that item is huge, does take it into account when it resizes \
> > the frame? )you would want the frame border, not the shadow more or less aligned \
> > with the window size)
no the border is not considered, but I think that's just fine. It's nothing you \
really notice that it is not exactly the same geometry and after all: it's just an \
outline.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/#review31539
-----------------------------------------------------------
On April 26, 2013, 8 a.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110176/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 8 a.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Description
> -------
>
> Change the visual appearance of the composited outline
>
> Uses widgets/translucentbackground as FrameSvg item to ensure that we
> don't get a huge black square on the screen.
>
> When bordering a screen edge we disable the border except if all edges
> are bordered. This makes a little bit more clear in the quick tiling case
> what will be the geometry.
>
> Blur behind the outline does not work as:
> * moving the window generates artefacts
> * moved window needs to be above the outline, but outline needs to be on
> top of everything. Elevating the moved window results in strange
> side effects when moving the window "below" a keep above, etc.
>
>
> Diffs
> -----
>
> kwin/geometry.cpp 5a6786d
> kwin/outline.cpp ad3cfc0
>
> Diff: http://git.reviewboard.kde.org/r/110176/diff/
>
>
> Testing
> -------
>
> I tried various Plasma theme elements. dialog/* and widgets/background are not \
> useable as there are solid themes.
>
> Thanks,
>
> Martin Gräßlin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110176/">http://git.reviewboard.kde.org/r/110176/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 25th, 2013, 11:10 a.m. CEST, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">seems a nice idea. since the shadow for that item is huge, does take it \
into account when it resizes the frame? )you would want the frame border, not the \
shadow more or less aligned with the window size)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no the border is not \
considered, but I think that's just fine. It's nothing you really notice that \
it is not exactly the same geometry and after all: it's just an outline.</pre> \
<br />
<p>- Martin</p>
<br />
<p>On April 26th, 2013, 8 a.m. CEST, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated April 26, 2013, 8 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change the visual appearance of the composited outline
Uses widgets/translucentbackground as FrameSvg item to ensure that we
don't get a huge black square on the screen.
When bordering a screen edge we disable the border except if all edges
are bordered. This makes a little bit more clear in the quick tiling case
what will be the geometry.
Blur behind the outline does not work as:
* moving the window generates artefacts
* moved window needs to be above the outline, but outline needs to be on
top of everything. Elevating the moved window results in strange
side effects when moving the window "below" a keep above, etc.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I tried various Plasma theme elements. dialog/* and widgets/background \
are not useable as there are solid themes.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/geometry.cpp <span style="color: grey">(5a6786d)</span></li>
<li>kwin/outline.cpp <span style="color: grey">(ad3cfc0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110176/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic