[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110122: Patch to handle notifications with low timeouts masking earlier important
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-04-25 14:02:46
Message-ID: 20130425140246.2294.26581 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110122/#review31563
-----------------------------------------------------------
sorry for the late reply; the people who could review this one were off in the last \
week at a dev sprint and reviews tend to get neglected when that happens. but better \
late than never, right? ;) looks pretty good, a few minor issues below, and Marco \
Martin should also have a glance through it.
plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml
<http://git.reviewboard.kde.org/r/110122/#comment23501>
no minimum is set here as there was in the prior code. there should probably be \
some sensible minimum applied.
plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml
<http://git.reviewboard.kde.org/r/110122/#comment23502>
this tends to lead to accidental timers running when the code changes later (QML \
makes it a little too easy to accomplish that at times ;)
would prefer that this stays as a single shot and is restarted as needed.
- Aaron J. Seigo
On April 25, 2013, 1:58 p.m., James Pike wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110122/
> -----------------------------------------------------------
>
> (Updated April 25, 2013, 1:58 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Currently the timeout of the last notification to arrive is used as a basis for \
> hiding the notification display. This means that a notification with a high timeout \
> can get hidden by a new notification arriving with a much lower timeout.
> This patch simply changes the behaviour to, when expiring a timer, go back through \
> the stack and display the most recent unexpired timer. If all timers are expired \
> the notification is closed as before.
>
> This addresses bug 318295.
> http://bugs.kde.org/show_bug.cgi?id=318295
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml 2fa1b11
>
> Diff: http://git.reviewboard.kde.org/r/110122/diff/
>
>
> Testing
> -------
>
> Test script in https://bugs.kde.org/show_bug.cgi?id=318295
>
>
> Thanks,
>
> James Pike
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110122/">http://git.reviewboard.kde.org/r/110122/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry for the late \
reply; the people who could review this one were off in the last week at a dev sprint \
and reviews tend to get neglected when that happens. but better late than never, \
right? ;) looks pretty good, a few minor issues below, and Marco Martin should also \
have a glance through it.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line52" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">47</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">lastNotificationTimer</span><span class="p">.</span><span \
class="nx">interval</span> <span class="o">=</span> <span class="nb"><span \
class="hl">Math</span></span><span class="p"><span class="hl">.</span></span><span \
class="nx"><span class="hl">max</span></span><span class="p"><span \
class="hl">(</span></span><span class="mi"><span class="hl">4000</span></span><span \
class="p"><span class="hl">,</span></span><span class="hl"> </span><span \
class="nb"><span class="hl">Math</span></span><span class="p"><span \
class="hl">.</span></span><span class="nx"><span class="hl">min</span></span><span \
class="p"><span class="hl">(</span></span><span class="mi"><span \
class="hl">60</span></span><span class="o"><span class="hl">*</span></span><span \
class="mi"><span class="hl">1000</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class \
="nx">notification<span class="hl">sModel</span></span><span class="p"><span \
class="hl">.</span></span><span class="nx"><span class="hl">get</span></span><span \
class="p"><span class="hl">(</span></span><span class="mi"><span \
class="hl">0</span></span><span class="p"><span class="hl">)</span>.</span><span \
class="nx">expireTimeout</span><span class="p"><span \
class="hl">))</span></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">52</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span \
class="nx">lastNotificationTimer</span><span class="p">.</span><span \
class="nx">interval</span> <span class="o">=</span> <span \
class="nx">notification</span><span class="p">.</span><span \
class="nx">expireTimeout</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no minimum \
is set here as there was in the prior code. there should probably be some sensible \
minimum applied.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110122/diff/1/?file=140373#file140373line188" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">160</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">repeat:</span> <span class="kc">false</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">188</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">repeat:</span> <span class="kc">true</span> <span class="c1">// to \
allow re-arm from onTriggered</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this tends \
to lead to accidental timers running when the code changes later (QML makes it a \
little too easy to accomplish that at times ;)
would prefer that this stays as a single shot and is restarted as needed.</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On April 25th, 2013, 1:58 p.m. UTC, James Pike wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By James Pike.</div>
<p style="color: grey;"><i>Updated April 25, 2013, 1:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently the timeout of the last notification to arrive is used as a \
basis for hiding the notification display. This means that a notification with a high \
timeout can get hidden by a new notification arriving with a much lower timeout.
This patch simply changes the behaviour to, when expiring a timer, go back through \
the stack and display the most recent unexpired timer. If all timers are expired the \
notification is closed as before.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Test script in https://bugs.kde.org/show_bug.cgi?id=318295</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318295">318295</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(2fa1b11)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110122/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic