'Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment ca'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110158: Fix crash in Plasma::Applet::configDialogFinished() in the containment ca
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-24 20:42:19
Message-ID: 20130424204219.11055.91101 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110158/
-----------------------------------------------------------

(Updated April 24, 2013, 8:42 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma and Aaron J. Seigo.

Description
-------

This patch fixes a crash tracked in KDE bug 318806.

94e1d5c (KDE/4.10) exposed a latent crash in Plasma::Applet::configDialogFinished(). \
configDialogFinished() checks whether the publishUi (the widget network sharing ()) \
has been initialized by checking whether publishUI.publishCheckbox is not null, \
however this is a uic-generated pointer, and uic generated classes don't zero-init \
their member pointers in the constructor. Plasma::Applet attempts to cope with this \
by initializing publishUI.publishCheckbox to 0 in showConfigurationInterface(), but \
this isn't run in the containment case, where things move through a signal handled by \
the shell instead. This patch adds a second zero-initialization of publishCheckbox in \
the AppletPrivate constructor to handle this case as well. I've chosen to keep the \
one in showConfigurationInterface() regardless to leave it context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.

This addresses bug 318806.
    http://bugs.kde.org/show_bug.cgi?id=318806

Diffs
-----

  plasma/applet.cpp 9ed62bc 

Diff: http://git.reviewboard.kde.org/r/110158/diff/

Testing
-------

Thanks,

Eike Hein

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110158/">http://git.reviewboard.kde.org/r/110158/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Eike Hein.</div>

<p style="color: grey;"><i>Updated April 24, 2013, 8:42 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch fixes a crash tracked in KDE bug 318806.

94e1d5c (KDE/4.10) exposed a latent crash in Plasma::Applet::configDialogFinished(). \
configDialogFinished() checks whether the publishUi (the widget network sharing ()) \
has been initialized by checking whether publishUI.publishCheckbox is not null, \
however this is a uic-generated pointer, and uic generated classes don&#39;t \
zero-init their member pointers in the constructor. Plasma::Applet attempts to cope \
with this by initializing publishUI.publishCheckbox to 0 in \
showConfigurationInterface(), but this isn&#39;t run in the containment case, where \
things move through a signal handled by the shell instead. This patch adds a second \
zero-initialization of publishCheckbox in the AppletPrivate constructor to handle \
this case as well. I&#39;ve chosen to keep the one in showConfigurationInterface() \
regardless to leave it context-free.

I would like to apply this patch to both the KDE/4.10 and master branches.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318806">318806</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applet.cpp <span style="color: grey">(9ed62bc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110158/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 