From kde-panel-devel Wed Apr 24 18:19:53 2013 From: "Varun Herale" Date: Wed, 24 Apr 2013 18:19:53 +0000 To: kde-panel-devel Subject: Re: Review Request 105319: DBus-interface for changing wallpapers Message-Id: <20130424181953.16853.89489 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136682761022024 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6038051975319485319==" --===============6038051975319485319== Content-Type: multipart/alternative; boundary="===============0955217410061520985==" --===============0955217410061520985== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote: > > Varun, it seems Aaron had some comments, can you have a look at them? Yes, I am looking at it right now. - Varun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/#review27009 ----------------------------------------------------------- On July 1, 2012, 5:56 a.m., Varun Herale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105319/ > ----------------------------------------------------------- > > (Updated July 1, 2012, 5:56 a.m.) > > > Review request for Plasma. > > > Description > ------- > > This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default "image" plugin, the path to the image can also be sent which will change the wallpaper. > > > Diffs > ----- > > plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 > plasma/desktop/shell/plasmaapp.h 6ae0c89 > plasma/desktop/shell/plasmaapp.cpp 7abd8fc > > Diff: http://git.reviewboard.kde.org/r/105319/diff/ > > > Testing > ------- > > Tested on different activities and made sure it works for per-virtual desktop containment. > > Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ? > > > Thanks, > > Varun Herale > > --===============0955217410061520985== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105319/

On February 8th, 2013, 9:48 p.m. UTC, Albert Astals Cid wrote:

Varun, it seems Aaron had some comments, can you have a look at them?
Yes, I am looking at it right now.

- Varun


On July 1st, 2012, 5:56 a.m. UTC, Varun Herale wrote:

Review request for Plasma.
By Varun Herale.

Updated July 1, 2012, 5:56 a.m.

Description 

This patch is for hosting a dbus-interface that can be used to load any installed wallpaper plugin onto current desktop containment. In case of default "image" plugin, the path to the image can also be sent which will change the wallpaper.

Testing 

Tested on different activities and made sure it works for per-virtual desktop containment.

Haven't tested on a system with multiple screens though, as I don't have access to one. Could someone please test for that ?

Diffs

  • plasma/desktop/shell/dbus/org.kde.plasma.App.xml (eefce32)
  • plasma/desktop/shell/plasmaapp.h (6ae0c89)
  • plasma/desktop/shell/plasmaapp.cpp (7abd8fc)

View Diff
--===============0955217410061520985==-- --===============6038051975319485319== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6038051975319485319==--