[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110135: Adjust to new suspend session handling
From: "Dario Freddi" <drf () kde ! org>
Date: 2013-04-23 19:54:08
Message-ID: 20130423195408.4954.63157 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31464
-----------------------------------------------------------
The patch is ok, but the changes to the service name are wrong. It should still stay \
org.freedesktop.PowerManagement. This is not to be confused with the comments to the \
previous patch, where basic actions could be found on the fd.o PowerManagement \
service - this signal should instead come from Solid's service, and as I said it \
should actually be a signal in the PowerManagement::Notifier class in libsolid. I'll \
see if I can include that in 4.11.
kcontrol/randr/module/randrmonitor.cpp
<http://git.reviewboard.kde.org/r/110135/#comment23443>
Indeed the service should remain the same (org.kde.Solid.PowerManagement). Note \
to self: we should add an API for this to libsolid.
ksmserver/shutdowndlg.cpp
<http://git.reviewboard.kde.org/r/110135/#comment23444>
Same here, the service should be the same as before
- Dario Freddi
On April 23, 2013, 7:12 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 7:12 p.m.)
>
>
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
>
>
> Description
> -------
>
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
>
>
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
>
>
> Diffs
> -----
>
> kcontrol/randr/module/randrmonitor.cpp 5a719a4
> ksmserver/screenlocker/greeter/greeterapp.cpp e54c216
> ksmserver/shutdowndlg.cpp 247c877
> plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37
> plasma/generic/dataengines/powermanagement/powermanagementjob.cpp 6f90006
> plasma/generic/dataengines/time/timeengine.cpp 2f69e8f
> plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d
>
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
>
>
> Testing
> -------
>
> Compiled, actions work now.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110135/">http://git.reviewboard.kde.org/r/110135/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch is ok, but the \
changes to the service name are wrong. It should still stay \
org.freedesktop.PowerManagement. This is not to be confused with the comments to the \
previous patch, where basic actions could be found on the fd.o PowerManagement \
service - this signal should instead come from Solid's service, and as I said it \
should actually be a signal in the PowerManagement::Notifier class in libsolid. \
I'll see if I can include that in 4.11.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110135/diff/2/?file=140639#file140639line280" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcontrol/randr/module/randrmonitor.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
RandrMonitorModule::isLidPresent()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">280</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QDBusConnection</span><span class="o">::</span><span \
class="n">sessionBus</span><span class="p">().</span><span \
class="n">connect</span><span class="p">(</span><span class="s">"org.<span \
class="hl">kde.</span>Solid<span class="hl">.</span>PowerManagement<span \
class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="s"><span class="hl">"/org/</span>kde<span \
class="hl">/</span>Solid<span class="hl">/</span>PowerManagement<span \
class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="s"><span \
class="hl">"org.kde.Solid.PowerManagement</span>"</span><span \
class="p">,</span> <span class="s">"resumingFromSuspend"</span><span \
class="p">,</span> <span class="k">this</span><span class="p">,</span> <span \
class="n">SLOT</spa n><span class="p">(</span><span \
class="n">resumedFromSuspend</span><span class="p">()));</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">280</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QDBusConnection</span><span class="o">::</span><span \
class="n">sessionBus</span><span class="p">().</span><span \
class="n">connect</span><span class="p">(</span><span class="s">"org.<span \
class="hl">freedesktop.PowerManagement"</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="s"><span \
class="hl">"/org/kde/</span>Solid<span class="hl">/</span>PowerManagement<span \
class="hl">/Actions/SuspendSession"</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="s"><span \
class="hl">"org.</span>kde<span class="hl">.</span>Solid<span \
class="hl">.</span>PowerManagement<span \
class="hl">.Actions.SuspendSession</span>"</span><span class="p">,</span> <span \
class="s">"resumingFromSuspend"</span><span class="p">,</span> <span \
class="k">this</span><s pan class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">resumedFromSuspend</span><span \
class="p">()));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed the \
service should remain the same (org.kde.Solid.PowerManagement). Note to self: we \
should add an API for this to libsolid.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/110135/diff/2/?file=140641#file140641line332" \
style="color: black; font-weight: bold; text-decoration: \
underline;">ksmserver/shutdowndlg.cpp</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KSMShutdownDlg::slotSuspend(int spdMethod)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">332</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">call</span> <span class="o">=</span> <span \
class="n">QDBusMessage</span><span class="o">::</span><span \
class="n">createMethodCall</span><span class="p">(</span><span \
class="s">"org.<span \
class="hl">kde.Solid</span>.PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">332</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">call</span> <span \
class="o">=</span> <span class="n">QDBusMessage</span><span class="o">::</span><span \
class="n">createMethodCall</span><span class="p">(</span><span \
class="s">"org.<span \
class="hl">freedesktop</span>.PowerManagement"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">333</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"/org/kde/Solid/PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">333</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="s">"/org/kde/Solid/PowerManagement<span \
class="hl">/Actions/SuspendSession</span>"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">334</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"org.kde.Solid.PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">334</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="s">"org.kde.Solid.PowerManagement<span \
class="hl">.Actions.SuspendSession</span>"</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">335</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"suspendToRam"</span><span class="p">);</span></pre></td> \
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">335</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"suspendToRam"</span><span class="p">);</span></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">336</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">break</span><span class="p">;</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">336</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">break</span><span class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">337</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Solid</span>:<span class="o">:</span><span \
class="n">PowerManagement</span><span class="o">::</span><span \
class="n">HibernateState</span><span class="o">:</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">337</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">case</span> <span class="n">Solid</span>:<span class="o">:</span><span \
class="n">PowerManagement</span><span class="o">::</span><span \
class="n">HibernateState</span><span class="o">:</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">338</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">call</span> <span class="o">=</span> <span \
class="n">QDBusMessage</span><span class="o">::</span><span \
class="n">createMethodCall</span><span class="p">(</span><span \
class="s">"org.<span \
class="hl">kde.Solid</span>.PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">338</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">call</span> <span \
class="o">=</span> <span class="n">QDBusMessage</span><span class="o">::</span><span \
class="n">createMethodCall</span><span class="p">(</span><span \
class="s">"org.<span \
class="hl">freedesktop</span>.PowerManagement"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">339</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"/org/kde/Solid/PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">339</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="s">"/org/kde/Solid/PowerManagement<span \
class="hl">/Actions/SuspendSession</span>"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">340</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="s">"org.kde.Solid.PowerManagement"</span><span \
class="p">,</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">340</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> \
<span class="s">"org.kde.Solid.PowerManagement<span \
class="hl">.Actions.SuspendSession</span>"</span><span \
class="p">,</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same here, \
the service should be the same as before</pre> </div>
<br />
<p>- Dario</p>
<br />
<p>On April 23rd, 2013, 7:12 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated April 23, 2013, 7:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Suspend/hibernate are now longer are part of \
org.kde.Solid.PowerManagement interface, so adjusting to new one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, actions work now.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318737">318737</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/module/randrmonitor.cpp <span style="color: \
grey">(5a719a4)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: \
grey">(e54c216)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(247c877)</span></li>
<li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: \
grey">(4e83c37)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span \
style="color: grey">(6f90006)</span></li>
<li>plasma/generic/dataengines/time/timeengine.cpp <span style="color: \
grey">(2f69e8f)</span></li>
<li>plasma/generic/runners/powerdevil/PowerDevilRunner.cpp <span style="color: \
grey">(74eb36d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110135/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic