[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110135: Adjust Kickoff actions to latest Powerdevil changes
From: "Dario Freddi" <drf () kde ! org>
Date: 2013-04-23 18:23:53
Message-ID: 20130423182353.4152.72066 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 23, 2013, 6:11 p.m., Lukáš Tinkl wrote:
> > Thanks for the patch but you should use the official FDO interface for that \
> > (org.freedesktop.PowerManagement)
>
> Hrvoje Senjan wrote:
> Lukáš, i just adjusted the interface from old to new one (which was also solid's, \
> not FDO's).
To me it's ok, as it is in Workspace and can be easily kept in sync.
- Dario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110135/#review31459
-----------------------------------------------------------
On April 23, 2013, 5:28 p.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110135/
> -----------------------------------------------------------
>
> (Updated April 23, 2013, 5:28 p.m.)
>
>
> Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.
>
>
> Description
> -------
>
> Suspend/hibernate are now longer are part of
> org.kde.Solid.PowerManagement interface, so adjusting to new one.
>
>
> This addresses bug 318737.
> http://bugs.kde.org/show_bug.cgi?id=318737
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37
>
> Diff: http://git.reviewboard.kde.org/r/110135/diff/
>
>
> Testing
> -------
>
> Compiled, actions work now.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110135/">http://git.reviewboard.kde.org/r/110135/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 23rd, 2013, 6:11 p.m. UTC, <b>Lukáš \
Tinkl</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Thanks for the patch but you should use the official FDO interface for \
that (org.freedesktop.PowerManagement)</pre> </blockquote>
<p>On April 23rd, 2013, 6:21 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Lukáš, i just adjusted \
the interface from old to new one (which was also solid's, not FDO's). </pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To me it's ok, as it \
is in Workspace and can be easily kept in sync.</pre> <br />
<p>- Dario</p>
<br />
<p>On April 23rd, 2013, 5:28 p.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated April 23, 2013, 5:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Suspend/hibernate are now longer are part of \
org.kde.Solid.PowerManagement interface, so adjusting to new one.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, actions work now.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318737">318737</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: \
grey">(4e83c37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110135/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic