From kde-panel-devel Sat Apr 20 13:46:02 2013 From: "Commit Hook" Date: Sat, 20 Apr 2013 13:46:02 +0000 To: kde-panel-devel Subject: Re: Review Request 110029: Fix X pixmap leak in shadow handling code Message-Id: <20130420134602.11401.21005 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136646558716102 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9031564111693589501==" --===============9031564111693589501== Content-Type: multipart/alternative; boundary="===============2994785385592891736==" --===============2994785385592891736== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110029/ ----------------------------------------------------------- (Updated April 20, 2013, 1:46 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Description ------- Some X pixmaps were never free-ed. The code got a little bit cleaned up by ensuring that the X Pixmap for the QPixmap is always created. This makes sense as we can be pretty sure that we are on the raster graphics system. Diffs ----- plasma/private/dialogshadows.cpp 481f7bd Diff: http://git.reviewboard.kde.org/r/110029/diff/ Testing ------- Tested locally, but I would prefer if someone else could confirm that the leak is gone. Thanks, Martin Gräßlin --===============2994785385592891736== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110029/

This change has been marked as submitted.

Review request for Plasma.

By Martin Gräßlin.

Updated April 20, 2013, 1:46 p.m.

Description

Some X pixmaps were never free-ed. The code got a little bit cleaned up by ensuring that the X Pixmap for the QPixmap is always created. This makes sense as we can be pretty sure that we are on the raster graphics system.

Testing

Tested locally, but I would prefer if someone else could confirm that the leak is gone.

Diffs

plasma/private/dialogshadows.cpp (481f7bd)

View Diff

--===============2994785385592891736==-- --===============9031564111693589501== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============9031564111693589501==--