'Re: Review Request 110029: Fix X pixmap leak in shadow handling code'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110029: Fix X pixmap leak in shadow handling code
From:       "Commit Hook" <null () kde ! org>
Date:       2013-04-20 13:45:53
Message-ID: 20130420134553.11596.41674 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110029/#review31331
-----------------------------------------------------------

This review has been submitted with commit b29820e09a0a0e355f6c8e743ca142af89118290 \
by Martin Gräßlin to branch KDE/4.10.

- Commit Hook

On April 15, 2013, 4:30 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110029/
> -----------------------------------------------------------
> 
> (Updated April 15, 2013, 4:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Some X pixmaps were never free-ed. The code got a little bit cleaned up by ensuring \
> that the X Pixmap for the QPixmap is always created. This makes sense as we can be \
> pretty sure that we are on the raster graphics system. 
> 
> Diffs
> -----
> 
> plasma/private/dialogshadows.cpp 481f7bd 
> 
> Diff: http://git.reviewboard.kde.org/r/110029/diff/
> 
> 
> Testing
> -------
> 
> Tested locally, but I would prefer if someone else could confirm that the leak is \
> gone. 
> 
> Thanks,
> 
> Martin Gräßlin
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110029/">http://git.reviewboard.kde.org/r/110029/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit b29820e09a0a0e355f6c8e743ca142af89118290 by Martin Gräßlin to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On April 15th, 2013, 4:30 p.m. UTC, Martin Gräßlin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated April 15, 2013, 4:30 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Some X pixmaps were never free-ed. The code got a little bit cleaned up \
by ensuring that the X Pixmap for the QPixmap is always created. This makes sense as \
we can be pretty sure that we are on the raster graphics system.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested locally, but I would prefer if someone else could confirm that \
the leak is gone.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/private/dialogshadows.cpp <span style="color: grey">(481f7bd)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110029/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 